From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: fan.du@windriver.com, fengguang.wu@intel.com, netdev@vger.kernel.org
Subject: Re: [PATCH] xfrm:Use rcu_dereference_bh to deference pointer protected by rcu_read_lock_bh
Date: Sun, 19 Aug 2012 11:58:46 +0200 [thread overview]
Message-ID: <1345370326.5158.23.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120816.232414.545877018277576779.davem@davemloft.net>
On Thu, 2012-08-16 at 23:24 -0700, David Miller wrote:
> I already applied your patch, as I told you here:
>
> http://marc.info/?l=linux-netdev&m=134517122805719&w=2
>
> This means you are submitting a patch which doesn't not even apply
> to the net-next tree.
>
> Instead of continuing to dig yourself deeper and deeper, take a
> break, take a deep breath, and work slowly and carefully.
> --
BTW, we (incorrectly ?) mix RCU and RCU_BH in this file, and since we
use synchronize_rcu() anyway, we should/could use rcu_read_lock()
everywhere we can, as this is less expensive (currently inlined at least
on x86) than rcu_read_lock_bh()
I'll send a cleanup patch on a separate thread
prev parent reply other threads:[~2012-08-19 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 6:19 [PATCH] xfrm:Use rcu_dereference_bh to deference pointer protected by rcu_read_lock_bh Fan Du
2012-08-17 6:24 ` David Miller
2012-08-17 6:36 ` Fan Du
2012-08-19 9:58 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345370326.5158.23.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=fan.du@windriver.com \
--cc=fengguang.wu@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox