Re: [PATCH] net: tcp: move sk_rx_dst_set call after tcp_create_openreq_child()

[Eric Dumazet <eric.dumazet@gmail.com>]

On Sat, 2012-08-18 at 23:56 -0400, Neal Cardwell wrote:
> This commit removes the sk_rx_dst_set calls from
> tcp_create_openreq_child(), because at that point the icsk_af_ops
> field of ipv6_mapped TCP sockets has not been set to its proper final
> value.
> 
> Instead, to make sure we get the right sk_rx_dst_set variant
> appropriate for the address family of the new connection, we have
> tcp_v{4,6}_syn_recv_sock() directly call the appropriate function
> shortly after the call to tcp_create_openreq_child() returns.
> 
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> Reported-by: Artem Savkov <artem.savkov@gmail.com>
> Cc: Eric Dumazet <edumazet@google.com>
> ---


>  		 * copy any s_data_payload stored at the original socket.
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index bb9ce2b..492c2d9 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -81,6 +81,8 @@ static void	__tcp_v6_send_check(struct sk_buff *skb,
>  				    const struct in6_addr *saddr,
>  				    const struct in6_addr *daddr);
>  
> +static void inet6_sk_rx_dst_set(struct sock *sk, const struct sk_buff *skb);
> +


Hi Neal, thanks for taking care of this.

Could you move inet6_sk_rx_dst_set() definition to avoid this forward ?