public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andrew Worsley <amworsley@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	James Morris <jmorris@namei.org>,
	netdev@vger.kernel.org
Subject: Re: network packet corruption in v3.6.0-rc1 (and also in v3.5)
Date: Sun, 19 Aug 2012 13:02:14 +0200	[thread overview]
Message-ID: <1345374134.5158.103.camel@edumazet-glaptop> (raw)
In-Reply-To: <CA+Y=x3=jSrEaYdnaAF75p0utQq02MhoSh4SkshRVSc7JjjVPOw@mail.gmail.com>

On Sat, 2012-08-18 at 16:40 +1000, Andrew Worsley wrote:
> Some times I get a burst of errors and dropped tcp connections with
> this warning. I had a similar issue with v3.5 (in fact v3.5 was
> unusable for https connections which would give bad MAC code messages
> at the application level)..
> 
> The issue seems better under v3.6-rc1 where as it was very bad under
> v3.5. Let me know if there is something I can do to avoid this
> problem. I am using the USB r8712u wireless NIC if that is relevant as
> I haven't been able to get the native wireless working under the MAC
> book yet (requires proprietary firmware extraction which I am not
> familiar with)
> 
> Much obliged if there is anything I can do to avoid it as it is rather
> annoying. Doesn't happen at all with my  Debian wheezy 3.2.0-2-amd64
> kernel.

OK, this seems to be related to r8712u, still in staging tree.

At first glance, its using a buggy skb_clone(), or kind of a 'reuse skb'
trick I have no time to investigate.

I suspect that some memory area are overwritten by this driver, and this
was not noticed with older kernels. With new kernels, its triggering a
WARN_ON() in tcp stack.

Any chance you can try to reproduce the bug with another adapter ?

  reply	other threads:[~2012-08-19 11:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-18  6:40 network packet corruption in v3.6.0-rc1 (and also in v3.5) Andrew Worsley
2012-08-19 11:02 ` Eric Dumazet [this message]
2012-08-19 20:20   ` Andrew Worsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345374134.5158.103.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=amworsley@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox