* [PATCH net-next] af_packet: use define instead of constant
@ 2012-08-20 13:34 Daniel Borkmann
2012-08-23 5:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Borkmann @ 2012-08-20 13:34 UTC (permalink / raw)
To: davem; +Cc: netdev
Instead of using a hard-coded value for the status variable, it would make
the code more readable to use its destined define from linux/if_packet.h.
Signed-off-by: daniel.borkmann@tik.ee.ethz.ch
---
net/packet/af_packet.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 226b2cd..3ee372a 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -855,7 +855,8 @@ static void prb_fill_vlan_info(struct tpacket_kbdq_core *pkc,
ppd->hv1.tp_vlan_tci = vlan_tx_tag_get(pkc->skb);
ppd->tp_status = TP_STATUS_VLAN_VALID;
} else {
- ppd->hv1.tp_vlan_tci = ppd->tp_status = 0;
+ ppd->hv1.tp_vlan_tci = 0;
+ ppd->tp_status = TP_STATUS_AVAILABLE;
}
}
@@ -1943,7 +1944,7 @@ static int tpacket_snd(struct packet_sock *po, struct msghdr *msg)
int tp_len, size_max;
unsigned char *addr;
int len_sum = 0;
- int status = 0;
+ int status = TP_STATUS_AVAILABLE;
int hlen, tlen;
mutex_lock(&po->pg_vec_lock);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] af_packet: use define instead of constant
2012-08-20 13:34 [PATCH net-next] af_packet: use define instead of constant Daniel Borkmann
@ 2012-08-23 5:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-08-23 5:58 UTC (permalink / raw)
To: danborkmann; +Cc: netdev
From: Daniel Borkmann <danborkmann@iogearbox.net>
Date: Mon, 20 Aug 2012 15:34:03 +0200
> Instead of using a hard-coded value for the status variable, it would make
> the code more readable to use its destined define from linux/if_packet.h.
>
> Signed-off-by: daniel.borkmann@tik.ee.ethz.ch
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-23 5:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-20 13:34 [PATCH net-next] af_packet: use define instead of constant Daniel Borkmann
2012-08-23 5:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).