Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dave Jones <davej@redhat.com>
Cc: netdev@vger.kernel.org,
	Fedora Kernel Team <kernel-team@fedoraproject.org>
Subject: Re: WARNING: at net/ipv4/tcp.c:1598 tcp_recvmsg+0x641/0xd30()
Date: Mon, 20 Aug 2012 18:42:52 +0200	[thread overview]
Message-ID: <1345480972.5158.330.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120820162050.GA25593@redhat.com>

On Mon, 2012-08-20 at 12:20 -0400, Dave Jones wrote:
> On Fri, Aug 10, 2012 at 10:40:18PM +0200, Eric Dumazet wrote:
>  
>  > >  >  > backtrace:
>  > >  >  > :WARNING: at net/ipv4/tcp.c:1598 tcp_recvmsg+0x641/0xd30()
>  > > 
>  > > We're getting more reports of this happening too.
>  > 
>  > Might be a driver issue with LRO / GRO/ TCP coalescing
>  > 
>  > So we need a _lot_ of details.
> 
> I looked over all the existing reports of this. It's a bit of a mess.
> It seems to affect multiple drivers.
> A big problem is that the network stack seems to get in a really screwed up state
> when this happens, and the automated bug filer files these corrupted traces.
> 
> A secondary problem is that because these are automated reports, not all users
> are responsive to answer questions afterwards...
> 
> Anyway, what I've gathered so far..
> 
> 3.4-rc	i2400m_usb      https://bugzilla.redhat.com/show_bug.cgi?id=807114
> 
> unknown (mangled traces) https://bugzilla.redhat.com/show_bug.cgi?id=841016
> 
> possibly e1000e (also mangled) https://bugzilla.redhat.com/show_bug.cgi?id=841769
> 
> 3.4.4	unknown (mangled)	https://bugzilla.redhat.com/show_bug.cgi?id=849275
>  (same guy, probably e1000e)	https://bugzilla.redhat.com/show_bug.cgi?id=849276
> 
> 3.5.0	r8712u  https://bugzilla.redhat.com/show_bug.cgi?id=845853
> 
> 3.5.0	unknown https://bugzilla.redhat.com/show_bug.cgi?id=846991
> 
> 
> any ideas on any additional debug printk's we could add ?
> 
> 	Dave
> 


We had a generic bug in old kernels, so you might ignore too old
reports.

This was fixed in commit 1ca7ee30630e1022dbcf1b51be20580815ffab73
(tcp: take care of overlaps in tcp_try_coalesce())

      reply	other threads:[~2012-08-20 16:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-06 15:46 WARNING: at net/ipv4/tcp.c:1598 tcp_recvmsg+0x641/0xd30() Dave Jones
2012-08-10 20:29 ` Dave Jones
2012-08-10 20:40   ` Eric Dumazet
2012-08-20 16:20     ` Dave Jones
2012-08-20 16:42       ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345480972.5158.330.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=davej@redhat.com \
    --cc=kernel-team@fedoraproject.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox