From: Eric Dumazet <eric.dumazet@gmail.com>
To: Pavel Emelyanov <xemul@parallels.com>
Cc: David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] packet: Protect packet sk list with mutex
Date: Mon, 20 Aug 2012 21:05:33 +0200 [thread overview]
Message-ID: <1345489533.5158.354.camel@edumazet-glaptop> (raw)
In-Reply-To: <50327D8A.5010400@parallels.com>
On Mon, 2012-08-20 at 22:10 +0400, Pavel Emelyanov wrote:
> AFAIU now this is the case for e.g. TCP sockets since they can be created in
> rx code. For packet I've found no places where these stats can be modified other
> than those two in af_packet.c
sock_prot_inuse_add() uses __this_cpu_add(), and on non x86, needs to be
safe against preemption ( or irq if applicable)
Changing spin_lock_bh() to mutex_lock() breaks this.
prev parent reply other threads:[~2012-08-20 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 14:50 [PATCH net-next] packet: Protect packet sk list with mutex Pavel Emelyanov
2012-08-20 15:11 ` Eric Dumazet
2012-08-20 18:10 ` Pavel Emelyanov
2012-08-20 19:05 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345489533.5158.354.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox