Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Sylvain Munaut <s.munaut@whatever-company.com>
Cc: netdev@vger.kernel.org
Subject: Re: IP fragmentation broken in 3.6-rc ?
Date: Tue, 21 Aug 2012 16:42:11 +0200	[thread overview]
Message-ID: <1345560131.5158.500.camel@edumazet-glaptop> (raw)
In-Reply-To: <1345555336.5158.493.camel@edumazet-glaptop>

On Tue, 2012-08-21 at 15:22 +0200, Eric Dumazet wrote:
> On Tue, 2012-08-21 at 15:05 +0200, Sylvain Munaut wrote:
> > Hi,
> > 
> > I'm starting to wonder if it's not related to
> > 46517008e1168dc926cf2c47d529efc07eca85c0 "ipv4: Kill
> > ip_rt_frag_needed()."
> > 
> > Cheers,
> > 
> >     Sylvain
> 
> Hmm, most probably problem came with commit
> ceb3320610d6f15ff20dd4c042b36473d77de76f
> (ipv4: Kill routes during PMTU/redirect updates.)
> 
> 

Following patch should help :

diff --git a/include/net/dst.h b/include/net/dst.h
index 621e351..a04aa37 100644
--- a/include/net/dst.h
+++ b/include/net/dst.h
@@ -435,7 +435,7 @@ static inline void dst_set_expires(struct dst_entry *dst, int timeout)
 	if (expires == 0)
 		expires = 1;
 
-	if (dst->expires == 0 || time_before(expires, dst->expires))
+	if (dst->expires == 0 || time_after(expires, dst->expires))
 		dst->expires = expires;
 }
 

  reply	other threads:[~2012-08-21 14:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21 13:05 IP fragmentation broken in 3.6-rc ? Sylvain Munaut
2012-08-21 13:22 ` Eric Dumazet
2012-08-21 14:42   ` Eric Dumazet [this message]
2012-08-21 16:34     ` Julian Anastasov
2012-08-21 16:47       ` Eric Dumazet
2012-08-21 17:18         ` Julian Anastasov
2012-08-21 17:23           ` Eric Dumazet
2012-08-21 20:00             ` Julian Anastasov
2012-08-21 20:46               ` Eric Dumazet
2012-08-21 21:07                 ` Julian Anastasov
2012-08-21 17:44     ` Sylvain Munaut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345560131.5158.500.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=s.munaut@whatever-company.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox