From: Eric Dumazet <eric.dumazet@gmail.com>
To: Sylvain Munaut <s.munaut@whatever-company.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>, Julian Anastasov <ja@ssi.bg>
Subject: Re: [PATCH] ipv4: properly update pmtu
Date: Wed, 22 Aug 2012 12:21:13 +0200 [thread overview]
Message-ID: <1345630873.5158.970.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAF6-1L77Z23dCfnee3nO3-V9U_tc1jz0ptXf9YcBcARGYnOvsw@mail.gmail.com>
On Wed, 2012-08-22 at 12:16 +0200, Sylvain Munaut wrote:
> Hi,
>
> > From: Eric Dumazet <edumazet@google.com>
>
> > ip_rt_update_pmtu() calls dst_set_expires() to rearm a new expiration,
> > but dst_set_expires() does nothing because dst.expires is already set.
> >
> > It seems we want to set the expires field to a new value, regardless
> > of prior one.
> >
> > With help from Julian Anastasov.
> >
> > Reported-by: Sylvain Munaut <s.munaut@whatever-company.com>
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > CC: Julian Anastasov <ja@ssi.bg>
>
> Tested-by: Sylvain Munaut <s.munaut@whatever-company.com>
>
> I confirm this corrects the issue for me. I tested this on 3 machines
> with 2 different hw config that all previously exhibited the issue
> short after boot and now they've been running with this version of the
> patch for hours without problems.
>
> @Eric: Thanks for looking into this.
Thans Sylvain for being an early tester of bleeding edge kernel !
next prev parent reply other threads:[~2012-08-22 10:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 6:48 [PATCH] ipv4: properly update pmtu Eric Dumazet
2012-08-22 10:16 ` Sylvain Munaut
2012-08-22 10:21 ` Eric Dumazet [this message]
2012-08-22 10:23 ` Eric Dumazet
2012-08-23 2:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345630873.5158.970.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=s.munaut@whatever-company.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox