Netdev List
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Roland Dreier <roland@kernel.org>
Cc: <netdev@vger.kernel.org>
Subject: Re: Best way to set kernel thread affinity for handling a socket?
Date: Wed, 22 Aug 2012 17:21:33 +0100	[thread overview]
Message-ID: <1345652493.2709.36.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <CAG4TOxNMRR_-bYJV1a_je2HKrpmVuGubH9ks4GdG8Shwa92K0w@mail.gmail.com>

On Wed, 2012-08-22 at 09:10 -0700, Roland Dreier wrote:
> Hi everyone,
> 
> Let's say I have kernel code that's sitting in a loop doing
> kernel_accept() on a TCP socket.  As each connection comes in, it
> forks off a kernel thread to deal with that socket.
> 
> If I have a modern NIC with RSS and multiple queues, each TCP flow is
> going to be steered to one queue, which is probably bound to one CPU.
> So when I fork off that kernel thread, I'd like to bind it to the CPU
> where its NIC queues are going to be processed.  My question is, how
> do I find out which CPU that is?  Is there anything in the new socket
> structure I get back from kernel_accept() that I can look at to know
> which CPU the packets came in on?

With RFS we try to do the reverse: move the packets to match the socket
user.   But it's not (yet) turned on by default.  See
Documentation/networking/scaling.txt

> I'm thinking about this in the context of the kernel's iSCSI target
> code (drivers/target/iscsi), which creates threads to handle each
> iSCSI connection and sets their CPU affinity pretty much randomly
> (well, based on some "thread id", cf iscsit_thread_get_cpumask()).

Why set the affinity at all?

> And with a modern NIC, this leads to packets being received on one CPU
> but the data being consumed on another CPU, all the time, which is
> obviously far from optimal.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

  reply	other threads:[~2012-08-22 16:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22 16:10 Best way to set kernel thread affinity for handling a socket? Roland Dreier
2012-08-22 16:21 ` Ben Hutchings [this message]
2012-08-23 17:04   ` Roland Dreier
2012-08-23 17:51     ` Ben Hutchings
2012-08-23 17:56     ` Chris Friesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345652493.2709.36.camel@bwh-desktop.uk.solarflarecom.com \
    --to=bhutchings@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=roland@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox