From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: David Miller <davem@davemloft.net>,
gaofeng@cn.fujitsu.com, netdev@vger.kernel.org,
maheshb@google.com, therbert@google.com
Subject: Re: [PATCH net-next v3] net: remove delay at device dismantle
Date: Thu, 23 Aug 2012 09:00:26 +0200 [thread overview]
Message-ID: <1345705226.5904.107.camel@edumazet-glaptop> (raw)
In-Reply-To: <87txvum80h.fsf@xmission.com>
On Wed, 2012-08-22 at 23:34 -0700, Eric W. Biederman wrote:
> raw_notifier_call_chain isn't safe without holding some sort of lock.
> So removing the ASSERT_RTNL assert here is papering over a bug elsewhere
> in this patch.
>
> Without holding a lock for traversing the notifier chain there will
> be races with network module load and unload that could corrupt
> this list while we are traversing it.
> load/unlod.
>
> You already have one of your NETDEV_UNREGISTER_FINAL calls under the
> rtnl_lock so it doesn't look like a burden to put the other call under
> the rtnl_lock as well.
Hmm right, I have been fooled by the rcu_dereference_raw() calls in
notifier_call_chain()
I'll send an update, thanks !
next prev parent reply other threads:[~2012-08-23 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 3:19 [PATCH net-next v3] net: remove delay at device dismantle Eric Dumazet
2012-08-23 4:33 ` Gao feng
2012-08-23 4:50 ` David Miller
2012-08-23 6:34 ` Eric W. Biederman
2012-08-23 7:00 ` Eric Dumazet [this message]
2012-08-23 18:21 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345705226.5904.107.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).