From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <amwang@redhat.com>
Cc: Debabrata Banerjee <dbavatar@gmail.com>,
netdev@vger.kernel.org, "Banerjee,
Debabrata" <dbanerje@akamai.com>,
"David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 1/2] ipv6: do not hold route table lock when send ndisc probe
Date: Thu, 23 Aug 2012 18:10:32 +0200 [thread overview]
Message-ID: <1345738232.5904.1244.camel@edumazet-glaptop> (raw)
In-Reply-To: <1345520643.12468.6.camel@cr0>
On Tue, 2012-08-21 at 11:44 +0800, Cong Wang wrote:
> Hi, Debabrata,
>
> Could you help to test the attached patch below?
>
> Thanks!
>
Hard to comment on your patch since its not inlined.
+ nw = kmalloc(sizeof(*nw), GFP_ATOMIC);
+ if (nw) {
+ memcpy(&nw->target, &neigh->primary_key, sizeof(struct in6_addr));
+ addrconf_addr_solict_mult(&nw->target, &nw->mcaddr);
+ nw->dev = rt->dst.dev;
+ INIT_WORK(&nw->work, queue_ndisc);
+ schedule_work(&nw->work);
+ }
You cant do that without taking extra reference on dev,
and release it in queue_ndisc()
This also will add interesting side effects at device dismantle.
next prev parent reply other threads:[~2012-08-23 16:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 7:11 [PATCH 1/2] ipv6: do not hold route table lock when send ndisc probe Cong Wang
2012-08-17 7:11 ` [PATCH 2/2] ipv6: remove some useless RCU read lock Cong Wang
2012-08-17 18:54 ` [PATCH 1/2] ipv6: do not hold route table lock when send ndisc probe Debabrata Banerjee
2012-08-20 12:15 ` Cong Wang
2012-08-21 3:44 ` Cong Wang
2012-08-22 16:04 ` Banerjee, Debabrata
2012-08-23 9:11 ` Cong Wang
2012-08-23 16:10 ` Eric Dumazet [this message]
2012-08-24 9:15 ` Cong Wang
2012-08-24 9:44 ` Eric Dumazet
2012-08-24 10:45 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345738232.5904.1244.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=dbanerje@akamai.com \
--cc=dbavatar@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox