From: Joe Perches <joe@perches.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "Vick, Matthew" <matthew.vick@intel.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>
Subject: Re: [net-next 11/13] igb: Update PTP function names/variables and locations.
Date: Fri, 24 Aug 2012 02:22:34 -0700 [thread overview]
Message-ID: <1345800154.16471.20.camel@joe2Laptop> (raw)
In-Reply-To: <20120824063240.GB2212@netboy.at.omicron.at>
On Fri, 2012-08-24 at 08:32 +0200, Richard Cochran wrote:
> On Thu, Aug 23, 2012 at 08:02:25PM -0700, Joe Perches wrote:
>
> > Improving code clarity and consistency isn't churn.
>
> This patch series moves code around for no good reason. That is, by
> definition, churn.
For your definition of good.
> > The most valuable form of code is the current one,
> > not any antecedent version.
>
> You really haven't noticed all the code review and rebasing that goes
> on around here in order to improve the commit history, have you?
That'd be incorrect too.
next prev parent reply other threads:[~2012-08-24 9:22 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 9:56 [net-next 00/13][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-08-23 9:56 ` [net-next 01/13] e1000e: use correct type for read of 32-bit register Jeff Kirsher
2012-08-23 9:56 ` [net-next 02/13] e1000e: cleanup strict checkpatch check Jeff Kirsher
2012-08-23 9:56 ` [net-next 03/13] e1000e: cleanup - remove inapplicable comment Jeff Kirsher
2012-08-23 9:56 ` [net-next 04/13] e1000e: cleanup checkpatch PREFER_PR_LEVEL warning Jeff Kirsher
2012-08-23 14:01 ` Joe Perches
2012-08-24 18:02 ` Joe Perches
2012-08-24 21:19 ` Jeff Kirsher
2012-08-24 22:43 ` Joe Perches
2012-08-23 9:56 ` [net-next 05/13] e1000e: cleanup - remove unnecessary variable Jeff Kirsher
2012-08-23 9:56 ` [net-next 06/13] e1000e: update driver version number Jeff Kirsher
2012-08-23 9:56 ` [net-next 07/13] e1000e: cleanup strict checkpatch MEMORY_BARRIER checks Jeff Kirsher
2012-08-23 9:56 ` [net-next 08/13] igb: Add loopback test support for i210 Jeff Kirsher
2012-08-23 9:56 ` [net-next 09/13] igb: reduce Rx header size Jeff Kirsher
2012-08-23 9:56 ` [net-next 10/13] igb: Tidy up wrapping for CONFIG_IGB_PTP Jeff Kirsher
2012-08-23 11:03 ` Richard Cochran
2012-08-23 16:09 ` Vick, Matthew
2012-08-23 17:29 ` Richard Cochran
2012-08-23 17:40 ` Vick, Matthew
2012-08-23 18:03 ` Richard Cochran
2012-08-23 18:03 ` Keller, Jacob E
2012-08-23 18:40 ` Vick, Matthew
2012-08-24 7:04 ` Richard Cochran
2012-08-24 10:10 ` Richard Cochran
2012-08-24 16:51 ` Ben Hutchings
2012-08-24 19:38 ` Keller, Jacob E
2012-08-25 6:20 ` Richard Cochran
2012-08-26 1:33 ` Keller, Jacob E
2012-08-26 13:01 ` Richard Cochran
2012-08-23 11:28 ` Richard Cochran
2012-08-23 16:27 ` Vick, Matthew
2012-08-23 9:56 ` [net-next 11/13] igb: Update PTP function names/variables and locations Jeff Kirsher
2012-08-23 11:16 ` Richard Cochran
2012-08-23 16:22 ` Vick, Matthew
2012-08-23 17:53 ` Richard Cochran
2012-08-23 18:00 ` Keller, Jacob E
2012-08-23 18:11 ` Richard Cochran
2012-08-23 18:44 ` Vick, Matthew
2012-08-24 6:55 ` Richard Cochran
2012-08-24 15:52 ` Vick, Matthew
2012-08-25 5:48 ` Richard Cochran
2012-08-27 15:23 ` Vick, Matthew
2012-08-27 16:44 ` Richard Cochran
2012-08-27 17:39 ` Vick, Matthew
2012-08-23 18:35 ` Vick, Matthew
2012-08-23 18:48 ` Keller, Jacob E
2012-08-23 18:58 ` Vick, Matthew
2012-08-24 3:02 ` Joe Perches
2012-08-24 6:32 ` Richard Cochran
2012-08-24 9:22 ` Joe Perches [this message]
2012-08-24 15:12 ` David Miller
2012-08-24 17:56 ` Joe Perches
2012-08-23 9:56 ` [net-next 12/13] igb: Correct PTP support query from ethtool Jeff Kirsher
2012-08-23 11:24 ` Richard Cochran
2012-08-23 16:38 ` Vick, Matthew
2012-08-23 9:56 ` [net-next 13/13] igb: Store the MAC address in the name in the PTP struct Jeff Kirsher
2012-08-23 10:45 ` Richard Cochran
2012-08-23 16:05 ` Vick, Matthew
2012-08-23 21:35 ` Ben Hutchings
2012-08-24 6:19 ` Richard Cochran
2012-09-06 23:04 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345800154.16471.20.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=matthew.vick@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).