From: Joe Perches <joe@perches.com>
To: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>
Cc: davem@davemloft.net, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com
Subject: Re: [PATCH] cs89x0 : packet reception not working
Date: Sun, 26 Aug 2012 15:26:01 -0700 [thread overview]
Message-ID: <1346019961.2064.4.camel@joe2Laptop> (raw)
In-Reply-To: <1346017146-28248-1-git-send-email-jaccon.bastiaansen@gmail.com>
On Sun, 2012-08-26 at 23:39 +0200, Jaccon Bastiaansen wrote:
> The RxCFG register of the CS89x0 could be configured incorrectly
> (because of misplaced parentheses), resulting in the disabling
> of packet reception.
Thanks.
> diff --git a/drivers/net/ethernet/cirrus/cs89x0.c b/drivers/net/ethernet/cirrus/cs89x0.c
[]
> @@ -1261,10 +1261,10 @@ static void set_multicast_list(struct net_device *dev)
> * so we have to enable interrupts on them also
> */
> writereg(dev, PP_RxCFG,
> - (lp->curr_rx_cfg |
> - (lp->rx_mode == RX_ALL_ACCEPT)
> - ? (RX_CRC_ERROR_ENBL | RX_RUNT_ENBL | RX_EXTRA_DATA_ENBL)
> - : 0));
> + lp->curr_rx_cfg |
> + (lp->rx_mode == RX_ALL_ACCEPT
> + ? (RX_CRC_ERROR_ENBL | RX_RUNT_ENBL | RX_EXTRA_DATA_ENBL)
> + : 0));
> spin_unlock_irqrestore(&lp->lock, flags);
> }
Perhaps it would be better to use something like:
int cfg = lp->curr_rx_cfg;
if (lp->rx_mode == RX_ALL_ACCEPT)
cfg |= RX_CRC_ERROR_ENBL | RX_RUNT_ENBL | RX_EXTRA_DATA_ENBL;
writereg(dev, PP_RxCFG, cfg);
prev parent reply other threads:[~2012-08-26 22:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 21:39 [PATCH] cs89x0 : packet reception not working Jaccon Bastiaansen
2012-08-26 22:26 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346019961.2064.4.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=jaccon.bastiaansen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).