From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Marchand <david.marchand@pace.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] Move in6_dev_hold under CONFIG_IPV6_PRIVACY
Date: Thu, 30 Aug 2012 08:25:21 -0700 [thread overview]
Message-ID: <1346340321.2586.24.camel@edumazet-glaptop> (raw)
In-Reply-To: <503F3589.5070804@pace.com>
On Thu, 2012-08-30 at 11:42 +0200, David Marchand wrote:
> Hello,
>
> I am currently looking at a problem with in6 interface refcnt on a
> really old kernel and I have just noticed something I find suspicious in
> all kernels until now.
>
> The comment at net/ipv6/addrconf.c:396 suggests that the call to
> in6_dev_hold is only for ipv6_regen_rndid.
> As a consequence, if CONFIG_IPV6_PRIVACY is not set, then this
> in6_dev_hold will leak a refcnt.
>
> Can someone look at this ?
> I did not test this patch, yet it looks reasonable to me.
Your patch was mangled by your email client, and its always safer to
test a patch...
Dont trust the comment, its a bit misleading.
Comment intent was to say :
/* One reference from device. We must do this before
* we eventually invoke __ipv6_regen_rndid().
*/
next prev parent reply other threads:[~2012-08-30 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 9:42 [RFC] Move in6_dev_hold under CONFIG_IPV6_PRIVACY David Marchand
2012-08-30 15:25 ` Eric Dumazet [this message]
2012-08-30 16:52 ` David Marchand
2012-08-30 17:28 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346340321.2586.24.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=david.marchand@pace.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).