From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Marchand <david.marchand@pace.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] Move in6_dev_hold under CONFIG_IPV6_PRIVACY
Date: Thu, 30 Aug 2012 10:28:32 -0700 [thread overview]
Message-ID: <1346347712.2586.29.camel@edumazet-glaptop> (raw)
In-Reply-To: <503F9A30.6030100@pace.com>
On Thu, 2012-08-30 at 18:52 +0200, David Marchand wrote:
> Mmm, ok.
> But if CONFIG_IPV6_PRIVACY is not selected, then I can't find where the associated in6_dev_put is done for this in6_dev_hold.
> Besides, __ipv6_regen_rndid is a "CONFIG_IPV6_PRIVACY-only" stuff.
>
Okay.
Look at addrconf_ifdown(), line 2850
in6_dev_put(idev);
Will finally remove the last reference
With your patch, I guess there will be a reference problem, and possibly
call in6_dev_finish_destroy() too soon.
You are mistaken, because the reference taken in PRIVACY is at line 421,
right before calling ipv6_regen_rndid()
Look at following commit to have an idea of the underlying problem
http://git.kernel.org/?p=linux/kernel/git/davem/net.git;a=commit;h=144d56e91044181ec0ef67aeca91e9a8b5718348
prev parent reply other threads:[~2012-08-30 17:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 9:42 [RFC] Move in6_dev_hold under CONFIG_IPV6_PRIVACY David Marchand
2012-08-30 15:25 ` Eric Dumazet
2012-08-30 16:52 ` David Marchand
2012-08-30 17:28 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346347712.2586.29.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=david.marchand@pace.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox