From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: proski@gnu.org, netdev@vger.kernel.org
Subject: Re: route.c:645 suspicious rcu_dereference_check()
Date: Fri, 31 Aug 2012 04:50:14 -0700 [thread overview]
Message-ID: <1346413814.2591.7.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120830.133433.566450758375930776.davem@davemloft.net>
On Thu, 2012-08-30 at 13:34 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 28 Aug 2012 15:33:07 -0700
>
> > From: Eric Dumazet <edumazet@google.com>
> >
> > [PATCH] ipv4: must use rcu protection while calling fib_lookup
> >
> > Following lockdep splat was reported by Pavel Roskin :
> ...
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > Reported-by: Pavel Roskin <proski@gnu.org>
>
> Applied, thanks.
>
> It looks like the redirect handlers might have the same problem?
Hi David
Correct me if I am wrong, but redirect handlers should all run under
rcu_read_lock() protection already.
rcu_read_lock() is done in ip_local_deliver_finish() or
ip_rt_send_redirect() for the forward path.
And above of them, we also have rcu_read_lock() done in
__netif_receive_skb()
next prev parent reply other threads:[~2012-08-31 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 21:57 route.c:645 suspicious rcu_dereference_check() Pavel Roskin
2012-08-28 22:33 ` Eric Dumazet
2012-08-30 17:34 ` David Miller
2012-08-31 11:50 ` Eric Dumazet [this message]
2012-08-31 20:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346413814.2591.7.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox