From: "Dave Täht" <dave.taht@bufferbloat.net>
To: Eric Dumazet <eric.dumazet@gmail.com>, netdev <netdev@vger.kernel.org>
Cc: Dave Taht <dave.taht@bufferbloat.net>
Subject: [PATCH] codel: reduce default maxpacket and reinitialize upon re-entering drop state
Date: Sat, 1 Sep 2012 11:50:57 -0700 [thread overview]
Message-ID: <1346525457-31481-1-git-send-email-dave.taht@bufferbloat.net> (raw)
From: Dave Taht <dave.taht@bufferbloat.net>
The minimum size packet in a queue is 64, not 256.
Also, as ethtool can be used to remove tso/gso/ufo, the last seen
maxpacket can vary considerably in size (e.g. 64k). So reset it
on re-entering the drop scheduler to the most recent packet size,
and let it grow again naturally.
Signed-off-by: Dave Taht <dave.taht@bufferbloat.net>
---
include/net/codel.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/net/codel.h b/include/net/codel.h
index 389cf62..0b0ac5e 100644
--- a/include/net/codel.h
+++ b/include/net/codel.h
@@ -170,7 +170,7 @@ static void codel_vars_init(struct codel_vars *vars)
static void codel_stats_init(struct codel_stats *stats)
{
- stats->maxpacket = 256;
+ stats->maxpacket = 64;
}
/*
@@ -333,6 +333,7 @@ static struct sk_buff *codel_dequeue(struct Qdisc *sch,
*/
codel_Newton_step(vars);
} else {
+ stats->maxpacket = skb ? qdisc_pkt_len(skb) : 64;
vars->count = 1;
vars->rec_inv_sqrt = ~0U >> REC_INV_SQRT_SHIFT;
}
--
1.7.9.5
next reply other threads:[~2012-09-01 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 18:50 Dave Täht [this message]
2012-09-02 23:05 ` [PATCH] codel: reduce default maxpacket and reinitialize upon re-entering drop state Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346525457-31481-1-git-send-email-dave.taht@bufferbloat.net \
--to=dave.taht@bufferbloat.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).