From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: davem@davemloft.net, Matthew Vick <matthew.vick@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 1/6] igb: Tidy up wrapping for CONFIG_IGB_PTP.
Date: Thu, 06 Sep 2012 01:44:27 -0700 [thread overview]
Message-ID: <1346921067.4228.12.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20120906080938.GE2550@netboy.at.omicron.at>
[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]
On Thu, 2012-09-06 at 10:09 +0200, Richard Cochran wrote:
> On Wed, Sep 05, 2012 at 04:35:01PM -0700, Jeff Kirsher wrote:
> > From: Matthew Vick <matthew.vick@intel.com>
> >
> > For users without CONFIG_IGB_PTP=y, we should not be compiling any
> PTP
> > code into the driver. Tidy up the wrapping in igb to support this.
>
> So, you have ignored everything I wrote about time stamping
> applications.
>
> (no)Thanks,
> Richard
As I recall, he stated he was going to integrate your suggestions in a
new patch set that would follow this one.
In regards to your previous comments about the earlier patch I submitted
to wrap the code. It was to fix a bug when the driver and time stamping
support are both modules.
Also, IMHO, while I look at pre-processor tags all day and get used to
matching up #ifdef to #endif's, I still see #endif /* CONFIG_IGB_PTP */
useful. While it is not currently consistent, I see it more useful to
fix as we go, rather than create a single patch to add a comment for
every #endif.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-06 8:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 23:35 [net-next 0/6][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-09-05 23:35 ` [net-next 1/6] igb: Tidy up wrapping for CONFIG_IGB_PTP Jeff Kirsher
2012-09-06 8:09 ` Richard Cochran
2012-09-06 8:44 ` Jeff Kirsher [this message]
2012-09-06 8:49 ` Richard Cochran
2012-09-06 9:04 ` Jeff Kirsher
2012-09-05 23:35 ` [net-next 2/6] igb: Update PTP function names/variables and locations Jeff Kirsher
2012-09-05 23:35 ` [net-next 3/6] igb: Correct PTP support query from ethtool Jeff Kirsher
2012-09-05 23:35 ` [net-next 4/6] igb: Store the MAC address in the name in the PTP struct Jeff Kirsher
2012-09-06 8:06 ` Richard Cochran
2012-09-06 22:59 ` Keller, Jacob E
2012-09-06 23:23 ` Ben Hutchings
2012-09-06 23:24 ` Keller, Jacob E
2012-09-06 23:39 ` Ben Hutchings
2012-09-06 23:40 ` Keller, Jacob E
2012-09-07 5:51 ` Richard Cochran
2012-09-05 23:35 ` [net-next 5/6] igb: Prevent dropped Tx timestamps via work items and interrupts Jeff Kirsher
2012-09-05 23:35 ` [net-next 6/6] igb: Add 1588 support to I210/I211 Jeff Kirsher
2012-09-06 8:13 ` [net-next 0/6][pull request] Intel Wired LAN Driver Updates Richard Cochran
2012-09-10 22:58 ` Vick, Matthew
2012-09-13 21:05 ` Jeff Kirsher
2012-09-17 4:53 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-09-17 9:21 Jeff Kirsher
2012-09-17 9:21 ` [net-next 1/6] igb: Tidy up wrapping for CONFIG_IGB_PTP Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346921067.4228.12.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=matthew.vick@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).