From: Ben Hutchings <bhutchings@solarflare.com>
To: Johan Gunnarsson <johan.gunnarsson@axis.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] ethtool: don't overwrite useful bits in advertising bitfield
Date: Thu, 6 Sep 2012 20:05:48 +0100 [thread overview]
Message-ID: <1346958348.2714.34.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <1345807965-16236-1-git-send-email-johangu@axis.com>
On Fri, 2012-08-24 at 13:32 +0200, Johan Gunnarsson wrote:
> There are bits in this bitfield that we want to leave untouched (PAUSE
> and ASYM_PAUSE bits) when changing other bits (speed and duplex bits.)
> Previously, these were always overwritten to zero when running commands
> like "ethtool -s eth0 speed 10 duplex full autoneg off".
>
> Signed-off-by: Johan Gunnarsson <johangu@axis.com>
[...]
Applied, thanks. I made some minor fixes to spelling and formatting.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2012-09-06 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 11:32 [PATCH v2] ethtool: don't overwrite useful bits in advertising bitfield Johan Gunnarsson
2012-09-06 19:05 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346958348.2714.34.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=johan.gunnarsson@axis.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox