From: Eric Dumazet <eric.dumazet@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv4/route: arg delay is useless in rt_cache_flush()
Date: Fri, 07 Sep 2012 12:29:54 +0200 [thread overview]
Message-ID: <1347013794.2484.488.camel@edumazet-glaptop> (raw)
In-Reply-To: <1347010284-3419-1-git-send-email-nicolas.dichtel@6wind.com>
On Fri, 2012-09-07 at 11:31 +0200, Nicolas Dichtel wrote:
> Since route cache deletion (89aef8921bfbac22f), delay is no
> more used. Remove it.
>
...
> #ifdef CONFIG_SYSCTL
> @@ -2354,16 +2350,12 @@ static int ipv4_sysctl_rtcache_flush(ctl_table *__ctl, int write,
> size_t *lenp, loff_t *ppos)
> {
> if (write) {
> - int flush_delay;
> ctl_table ctl;
> struct net *net;
>
> memcpy(&ctl, __ctl, sizeof(ctl));
> - ctl.data = &flush_delay;
> - proc_dointvec(&ctl, write, buffer, lenp, ppos);
> -
> net = (struct net *)__ctl->extra1;
> - rt_cache_flush(net, flush_delay);
> + rt_cache_flush(net);
> return 0;
> }
>
Why do you keep ctl then ?
if (write) {
rt_cache_flush((struct net *)__ctl->extra1);
return 0;
}
next prev parent reply other threads:[~2012-09-07 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 9:31 [PATCH net-next] ipv4/route: arg delay is useless in rt_cache_flush() Nicolas Dichtel
2012-09-07 10:29 ` Eric Dumazet [this message]
2012-09-07 10:41 ` Nicolas Dichtel
2012-09-07 10:45 ` [PATCH net-next v2] " Nicolas Dichtel
2012-09-07 15:24 ` Eric Dumazet
2012-09-07 18:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347013794.2484.488.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox