From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH 1/2] dst: take into account policy update on check() Date: Fri, 07 Sep 2012 16:35:10 +0200 Message-ID: <1347028510.2484.736.camel@edumazet-glaptop> References: <5049FAE3.2050403@6wind.com> <1347033467-3757-1-git-send-email-nicolas.dichtel@6wind.com> <1347033467-3757-2-git-send-email-nicolas.dichtel@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: vyasevich@gmail.com, davem@davemloft.net, sri@us.ibm.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org To: Nicolas Dichtel Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:39045 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753482Ab2IGOfR (ORCPT ); Fri, 7 Sep 2012 10:35:17 -0400 In-Reply-To: <1347033467-3757-2-git-send-email-nicolas.dichtel@6wind.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2012-09-07 at 17:57 +0200, Nicolas Dichtel wrote: > When a xfrm policy is inserted or deleted, we must invalidate > all dst and recalculate the route. > > Signed-off-by: Nicolas Dichtel > --- > include/net/dst.h | 7 +++++++ > net/core/dst.c | 1 + > net/core/sock.c | 4 ++-- > net/ipv6/ip6_tunnel.c | 3 +-- > 4 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/include/net/dst.h b/include/net/dst.h > index 9a78810..478e55a 100644 > --- a/include/net/dst.h > +++ b/include/net/dst.h > @@ -101,6 +101,9 @@ struct dst_entry { > atomic_t __refcnt; /* client references */ > int __use; > unsigned long lastuse; > +#ifdef CONFIG_XFRM > + u32 flow_cache_genid; > +#endif > union { > struct dst_entry *next; > struct rtable __rcu *rt_next; > @@ -457,6 +460,10 @@ static inline int dst_input(struct sk_buff *skb) > > static inline struct dst_entry *dst_check(struct dst_entry *dst, u32 cookie) > { > +#ifdef CONFIG_XFRM > + if (dst->flow_cache_genid != atomic_read(&flow_cache_genid)) > + return NULL; > +#endif Hmm... cant we reuse rt_genid ? (When changing flow_cache_genid, change &net->ipv4.rt_genid)