From: Eric Dumazet <eric.dumazet@gmail.com>
To: Chema Gonzalez <chema@google.com>
Cc: David Miller <davem@davemloft.net>,
edumazet@google.com, netdev@vger.kernel.org,
Chema Gonzalez <chema@berkeley.edu>
Subject: Re: [PATCH] net: small bug on rxhash calculation
Date: Sat, 08 Sep 2012 10:18:40 +0200 [thread overview]
Message-ID: <1347092320.1234.335.camel@edumazet-glaptop> (raw)
In-Reply-To: <1347061251-2019-1-git-send-email-chema@google.com>
On Fri, 2012-09-07 at 16:40 -0700, Chema Gonzalez wrote:
> In the current rxhash calculation function, while the
> sorting of the ports/addrs is coherent (you get the
> same rxhash for packets sharing the same 4-tuple, in
> both directions), ports and addrs are sorted
> independently. This implies packets from a connection
> between the same addresses but crossed ports hash to
> the same rxhash.
>
> For example, traffic between A=S:l and B=L:s is hashed
> (in both directions) from {L, S, {s, l}}. The same
> rxhash is obtained for packets between C=S:s and D=L:l.
>
> This patch ensures that you either swap both addrs and ports,
> or you swap none. Traffic between A and B, and traffic
> between C and D, get their rxhash from different sources
> ({L, S, {l, s}} for A<->B, and {L, S, {s, l}} for C<->D)
>
> The patch is co-written with Eric Dumazet <edumazet@google.com>
>
> Signed-off-by: Chema Gonzalez <chema@google.com>
> ---
Signed-off-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2012-09-08 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 6:35 [PATCH] net: Small bug on rxhash calculation Chema Gonzalez
2012-09-06 6:42 ` Eric Dumazet
2012-09-07 16:57 ` David Miller
2012-09-07 23:40 ` [PATCH] net: small " Chema Gonzalez
2012-09-07 23:40 ` Chema Gonzalez
2012-09-07 23:50 ` David Miller
2012-09-08 0:24 ` Chema Gonzalez
2012-09-08 8:18 ` Eric Dumazet [this message]
2012-09-08 22:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347092320.1234.335.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=chema@berkeley.edu \
--cc=chema@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox