netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: vyasevich@gmail.com, davem@davemloft.net, eric.dumazet@gmail.com
Cc: sri@us.ibm.com, linux-sctp@vger.kernel.org,
	netdev@vger.kernel.org,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: [PATCH net-next v2 1/4] netns: move net->ipv4.rt_genid to net->rt_genid
Date: Mon, 10 Sep 2012 15:22:15 +0200	[thread overview]
Message-ID: <1347283338-4249-2-git-send-email-nicolas.dichtel@6wind.com> (raw)
In-Reply-To: <1347283338-4249-1-git-send-email-nicolas.dichtel@6wind.com>

This commit prepares the use of rt_genid by both IPv4 and IPv6.
Initialization is left in IPv4 part.

Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
 include/net/net_namespace.h | 10 ++++++++++
 include/net/netns/ipv4.h    |  1 -
 net/ipv4/route.c            |  9 ++-------
 3 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h
index 5ae57f1..037190a 100644
--- a/include/net/net_namespace.h
+++ b/include/net/net_namespace.h
@@ -107,6 +107,7 @@ struct net {
 #endif
 	struct netns_ipvs	*ipvs;
 	struct sock		*diag_nlsk;
+	atomic_t		rt_genid;
 };
 
 /*
@@ -312,5 +313,14 @@ static inline void unregister_net_sysctl_table(struct ctl_table_header *header)
 }
 #endif
 
+static inline int rt_genid(struct net *net)
+{
+	return atomic_read(&net->rt_genid);
+}
+
+static inline void rt_genid_bump(struct net *net)
+{
+	atomic_inc(&net->rt_genid);
+}
 
 #endif /* __NET_NET_NAMESPACE_H */
diff --git a/include/net/netns/ipv4.h b/include/net/netns/ipv4.h
index 7d00583..2ae2b83 100644
--- a/include/net/netns/ipv4.h
+++ b/include/net/netns/ipv4.h
@@ -64,7 +64,6 @@ struct netns_ipv4 {
 	kgid_t sysctl_ping_group_range[2];
 	long sysctl_tcp_mem[3];
 
-	atomic_t rt_genid;
 	atomic_t dev_addr_genid;
 
 #ifdef CONFIG_IP_MROUTE
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index d39edf1..8ff984b 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -202,11 +202,6 @@ EXPORT_SYMBOL(ip_tos2prio);
 static DEFINE_PER_CPU(struct rt_cache_stat, rt_cache_stat);
 #define RT_CACHE_STAT_INC(field) __this_cpu_inc(rt_cache_stat.field)
 
-static inline int rt_genid(struct net *net)
-{
-	return atomic_read(&net->ipv4.rt_genid);
-}
-
 #ifdef CONFIG_PROC_FS
 static void *rt_cache_seq_start(struct seq_file *seq, loff_t *pos)
 {
@@ -449,7 +444,7 @@ static inline bool rt_is_expired(const struct rtable *rth)
 
 void rt_cache_flush(struct net *net)
 {
-	atomic_inc(&net->ipv4.rt_genid);
+	rt_genid_bump(net);
 }
 
 static struct neighbour *ipv4_neigh_lookup(const struct dst_entry *dst,
@@ -2506,7 +2501,7 @@ static __net_initdata struct pernet_operations sysctl_route_ops = {
 
 static __net_init int rt_genid_init(struct net *net)
 {
-	atomic_set(&net->ipv4.rt_genid, 0);
+	atomic_set(&net->rt_genid, 0);
 	get_random_bytes(&net->ipv4.dev_addr_genid,
 			 sizeof(net->ipv4.dev_addr_genid));
 	return 0;
-- 
1.7.12

  reply	other threads:[~2012-09-10 13:22 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06 17:40 [PATCH] sctp: check dst validity after IPsec operations Nicolas Dichtel
2012-09-06 16:04 ` Vlad Yasevich
2012-09-06 16:40   ` Nicolas Dichtel
2012-09-06 17:03     ` Vlad Yasevich
2012-09-07 12:24       ` Nicolas Dichtel
2012-09-07 12:07   ` Nicolas Dichtel
2012-09-06 18:10 ` David Miller
2012-09-07 13:47   ` Nicolas Dichtel
2012-09-07 15:57     ` [PATCH RFC net-next 0/2] Take care of xfrm policy when checking dst entries Nicolas Dichtel
2012-09-07 15:57       ` [PATCH 1/2] dst: take into account policy update on check() Nicolas Dichtel
2012-09-07 14:20         ` Vlad Yasevich
2012-09-07 14:35         ` Eric Dumazet
2012-09-07 14:47           ` Nicolas Dichtel
2012-09-07 15:09             ` Eric Dumazet
2012-09-07 15:13               ` Nicolas Dichtel
2012-09-07 15:21                 ` Eric Dumazet
2012-09-07 18:48                   ` David Miller
2012-09-07 18:48                 ` David Miller
2012-09-10 12:47                   ` Nicolas Dichtel
2012-09-10 13:10                     ` Eric Dumazet
2012-09-10 13:22                   ` [PATCH net-next v2] Take care of xfrm policy when checking dst entries Nicolas Dichtel
2012-09-10 13:22                     ` Nicolas Dichtel [this message]
2012-09-10 13:22                     ` [PATCH net-next v2 2/4] xfrm: invalidate dst on policy insertion/deletion Nicolas Dichtel
2012-09-10 14:21                       ` Vlad Yasevich
2012-09-10 14:56                         ` Nicolas Dichtel
2012-09-11  8:09                           ` [PATCH net-next v3 0/4] Take care of xfrm policy when checking dst entries Nicolas Dichtel
2012-09-11  8:09                             ` [PATCH net-next v3 1/4] netns: move net->ipv4.rt_genid to net->rt_genid Nicolas Dichtel
2012-09-11  8:09                             ` [PATCH net-next v3 2/4] xfrm: invalidate dst on policy insertion/deletion Nicolas Dichtel
2012-09-11  8:09                             ` [PATCH net-next v3 3/4] ipv6: use net->rt_genid to check dst validity Nicolas Dichtel
2012-09-11  8:09                             ` [PATCH net-next v3 4/4] ipv6: use DST_* macro to set obselete field Nicolas Dichtel
2012-09-12  7:40                               ` Eric Dumazet
2012-09-17 16:49                             ` [PATCH net-next v3 0/4] Take care of xfrm policy when checking dst entries David Miller
2012-09-17 18:14                               ` Vlad Yasevich
2012-09-17 18:25                                 ` David Miller
2012-09-17 19:52                                   ` Nicolas Dichtel
2012-09-17 19:54                                     ` David Miller
2012-09-18 20:08                                       ` David Miller
2012-09-10 13:22                     ` [PATCH net-next v2 3/4] ipv6: use net->rt_genid to check dst validity Nicolas Dichtel
2012-09-10 14:29                       ` Vlad Yasevich
2012-09-10 14:34                         ` Nicolas Dichtel
2012-09-10 14:43                           ` Vlad Yasevich
2012-09-10 14:44                             ` Nicolas Dichtel
2012-09-10 13:22                     ` [PATCH net-next v2 4/4] ipv6: use DST_* macro to set obselete field Nicolas Dichtel
2012-09-10 14:35                     ` [PATCH net-next v2] Take care of xfrm policy when checking dst entries Vlad Yasevich
2012-09-10 14:38                       ` Nicolas Dichtel
2012-09-10 17:18                       ` David Miller
2012-09-10 17:59                         ` Vlad Yasevich
2012-09-10 18:01                           ` David Miller
2012-09-22 16:49                             ` Jan Engelhardt
2012-09-07 14:51           ` [PATCH 1/2] dst: take into account policy update on check() Vlad Yasevich
2012-09-07 15:08             ` Eric Dumazet
2012-09-07 15:57       ` [PATCH 2/2] ipv6: remove rt6i_flow_cache_genid field in rt6_info Nicolas Dichtel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347283338-4249-2-git-send-email-nicolas.dichtel@6wind.com \
    --to=nicolas.dichtel@6wind.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sri@us.ibm.com \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).