From: Ben Hutchings <bhutchings@solarflare.com>
To: Sony Chacko <sony.chacko@qlogic.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<Dept_NX_Linux_NIC_Driver@qlogic.com>
Subject: Re: [PATCH 06/12] qlcnic: 83xx data path and HW interfaces routines
Date: Mon, 10 Sep 2012 17:54:29 +0100 [thread overview]
Message-ID: <1347296069.2823.9.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <1347058893-30165-7-git-send-email-sony.chacko@qlogic.com>
On Fri, 2012-09-07 at 19:01 -0400, Sony Chacko wrote:
> From: Sony Chacko <sony.chacko@qlogic.com>
>
> Modify 82xx driver to support new adapter - Qlogic 83XX CNA
> Create 83xx adapter data path and hardware interface routines
[...]
> +int qlcnic_83xx_set_pauseparam(struct qlcnic_adapter *adapter,
> + struct ethtool_pauseparam *pause)
> +{
> + int status = 0;
> + u32 config = adapter->ahw->port_config;
> +
> + if ((pause->rx_pause) || (pause->tx_pause) || (pause->autoneg))
> + adapter->ahw->port_config |= QLC_83XX_CFG_PAUSE_STD;
> + else if (!(pause->rx_pause && pause->tx_pause && pause->autoneg))
Since you appear to support only all-enabled or all-disabled, this
second condition should be:
!pause->rx_pause && !pause->tx_pause && !pause->autoneg
> + adapter->ahw->port_config &= ~QLC_83XX_CFG_PAUSE_STD;
> + else
> + return -EINVAL;
[...]
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> @@ -35,28 +35,31 @@ char qlcnic_driver_name[] = "qlcnic";
[...]
> -static int use_msi = 1;
> +int use_msi = 1;
> module_param(use_msi, int, 0444);
> MODULE_PARM_DESC(use_msi, "MSI interrupt (0=disabled, 1=enabled");
>
> -static int use_msi_x = 1;
> +int use_msi_x = 1;
> module_param(use_msi_x, int, 0444);
> MODULE_PARM_DESC(use_msi_x, "MSI-X interrupt (0=disabled, 1=enabled");
>
> -static int auto_fw_reset = 1;
> +int auto_fw_reset = 1;
> module_param(auto_fw_reset, int, 0644);
> MODULE_PARM_DESC(auto_fw_reset, "Auto firmware reset (0=disabled, 1=enabled");
>
> -static int load_fw_file;
> +int load_fw_file;
> module_param(load_fw_file, int, 0444);
> MODULE_PARM_DESC(load_fw_file, "Load firmware from (0=flash, 1=file");
[...]
All the variables being declared extern need to be renamed to have a
'qlcnic_' prefix. (The parameters shouldn't be renamed, though - use
module_param_named().)
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-09-10 16:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 23:01 [PATCH 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-09-07 23:01 ` [PATCH 01/12] qlcnic: Refactoring - template based hardware interface Sony Chacko
2012-09-07 23:01 ` [PATCH 02/12] qlcnic: Refactoring - Tx/Rx code path separation Sony Chacko
2012-09-07 23:01 ` [PATCH 03/12] qlcnic: Refactoring - Moving hw specific data to hardware context Sony Chacko
2012-09-07 23:01 ` [PATCH 04/12] qlcnic: remove 82xx specific register dump utility Sony Chacko
2012-09-07 23:01 ` [PATCH 05/12] qlcnic: change driver firmware interface mechanism Sony Chacko
2012-09-07 23:01 ` [PATCH 06/12] qlcnic: 83xx data path and HW interfaces routines Sony Chacko
2012-09-10 16:54 ` Ben Hutchings [this message]
2012-09-07 23:01 ` [PATCH 07/12] qlcnic: 83xx adpater flash interface routines Sony Chacko
2012-09-07 23:01 ` [PATCH 08/12] qlcnic: 83xx CNA inter driver communication mechanism Sony Chacko
2012-09-07 23:01 ` [PATCH 09/12] qlcnic: enable 83xx virtual NIC mode Sony Chacko
2012-09-07 23:01 ` [PATCH 10/12] qlcnic: register dump utility Sony Chacko
2012-09-07 23:01 ` [PATCH 11/12] qlcnic: 83xx adpater ethtool Sony Chacko
2012-09-07 23:01 ` [PATCH 12/12] qlcnic: update driver version - 5.1.30 Sony Chacko
-- strict thread matches above, loose matches on Subject: below --
2012-09-06 6:21 [PATCH 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-09-06 6:22 ` [PATCH 06/12] qlcnic: 83xx data path and HW interfaces routines Sony Chacko
2012-09-06 17:33 ` Ben Hutchings
2012-08-31 22:36 [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-08-31 22:36 ` [PATCH 06/12] qlcnic: 83xx data path and HW interfaces routines Sony Chacko
2012-08-31 6:28 [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-08-31 6:28 ` [PATCH 06/12] qlcnic: 83xx data path and HW interfaces routines Sony Chacko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347296069.2823.9.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox