From: Eric Dumazet <eric.dumazet@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
netdev <netdev@vger.kernel.org>
Subject: [PATCH] staging: r8712u: fix bug in r8712_recv_indicatepkt()
Date: Mon, 10 Sep 2012 19:55:15 +0200 [thread overview]
Message-ID: <1347299715.1234.1902.camel@edumazet-glaptop> (raw)
In-Reply-To: <1347289446.1234.1717.camel@edumazet-glaptop>
From: Eric Dumazet <edumazet@google.com>
64bit arches have a buggy r8712u driver, let's fix it.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
drivers/staging/rtl8712/recv_linux.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8712/recv_linux.c b/drivers/staging/rtl8712/recv_linux.c
index 0e26d5f..495ee12 100644
--- a/drivers/staging/rtl8712/recv_linux.c
+++ b/drivers/staging/rtl8712/recv_linux.c
@@ -117,13 +117,8 @@ void r8712_recv_indicatepkt(struct _adapter *padapter,
if (skb == NULL)
goto _recv_indicatepkt_drop;
skb->data = precv_frame->u.hdr.rx_data;
-#ifdef NET_SKBUFF_DATA_USES_OFFSET
- skb->tail = (sk_buff_data_t)(precv_frame->u.hdr.rx_tail -
- precv_frame->u.hdr.rx_head);
-#else
- skb->tail = (sk_buff_data_t)precv_frame->u.hdr.rx_tail;
-#endif
skb->len = precv_frame->u.hdr.len;
+ skb_set_tail_pointer(skb, skb->len);
if ((pattrib->tcpchk_valid == 1) && (pattrib->tcp_chkrpt == 1))
skb->ip_summed = CHECKSUM_UNNECESSARY;
else
next prev parent reply other threads:[~2012-09-10 17:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50369925.3050705@lwfinger.net>
[not found] ` <1345757200.5904.1890.camel@edumazet-glaptop>
[not found] ` <50378B35.80307@lwfinger.net>
[not found] ` <20120824.111948.680531915905273128.davem@davemloft.net>
[not found] ` <5037A4B0.3080208@lwfinger.net>
[not found] ` <1345825095.19483.19.camel@edumazet-glaptop>
[not found] ` <1345825432.19483.20.camel@edumazet-glaptop>
[not found] ` <5037B2AC.50704@lwfinger.net>
[not found] ` <1345830424.19483.69.camel@edumazet-glaptop>
[not found] ` <503BB49C.5010402@lwfinger.net>
[not found] ` <503BB49C.5010402-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2012-09-10 8:39 ` Regression associated with commit c8628155ece3 - "tcp: reduce out_of_order memory use" Eric Dumazet
2012-09-10 14:53 ` Larry Finger
[not found] ` <504DFEFF.6060004-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2012-09-10 15:04 ` Eric Dumazet
2012-09-10 17:55 ` Eric Dumazet [this message]
2012-09-10 18:34 ` [PATCH] staging: r8712u: fix bug in r8712_recv_indicatepkt() Larry Finger
2012-09-10 19:22 Eric Dumazet
2012-09-10 19:40 ` Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2012-09-12 17:52 Aki Parviainen
2012-09-12 18:25 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347299715.1234.1902.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox