From: Eric Dumazet <eric.dumazet@gmail.com>
To: Or Gerlitz <or.gerlitz@gmail.com>
Cc: Shlomo Pongartz <shlomop@mellanox.com>, netdev@vger.kernel.org
Subject: Re: ndo_get_stats and rtnl_netlink
Date: Mon, 10 Sep 2012 21:15:14 +0200 [thread overview]
Message-ID: <1347304514.1234.1993.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAJZOPZKKca6Yea=E9reL+x-cfvX0HwsgLAWKzjonmGwutH0MxA@mail.gmail.com>
On Mon, 2012-09-10 at 22:10 +0300, Or Gerlitz wrote:
> On Mon, Sep 10, 2012 at 12:09 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> > RTNL locking is not needed to fetch stats, and would be overkill.
> > Each driver has its own way to protect/gather its stats.
>
> FWIW, again, when dev_get_stats is called from rtnl_fill_ifinfo e.g as
> of invocation
> of "ip link show <interface>, there IS RTNL locking, is that a problem?
>
> Or.
Why should it be a problem ?
A dev_get_stats() is not allowed to sleep, so its not allowed to use
RTNL by itself.
So caller might use RTNL, we dont care at all.
prev parent reply other threads:[~2012-09-10 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 15:23 ndo_get_stats and rtnl_netlink Shlomo Pongartz
2012-09-10 9:09 ` Eric Dumazet
2012-09-10 19:10 ` Or Gerlitz
2012-09-10 19:15 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347304514.1234.1993.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=shlomop@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox