From: Cong Wang <amwang@redhat.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: RE: [PATCH 2/3] ipv6, route: remove BACKTRACK() macro
Date: Tue, 11 Sep 2012 09:07:37 +0800 [thread overview]
Message-ID: <1347325657.30731.5.camel@cr0> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B6FE6@saturn3.aculab.com>
On Mon, 2012-09-10 at 14:54 +0100, David Laight wrote:
>
> It does, however, seem to avoid replicating some relatively complex logic.
> OTOH goto out of a #define and hidden parameters (rt, fn ...) are not nice.
>
> Maybe the 'while (1)' part can be an inline function?
>
Yeah, actually that goto is the main reason why I think it should be
removed, at least I myself have some difficult to read this code which
jumps out. ;)
next prev parent reply other threads:[~2012-09-11 1:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 12:48 [PATCH 1/3] ipv6: remove some useless RCU read lock Cong Wang
2012-09-10 12:48 ` [PATCH 2/3] ipv6, route: remove BACKTRACK() macro Cong Wang
2012-09-10 13:43 ` Shan Wei
2012-09-11 1:22 ` Cong Wang
2012-09-10 13:54 ` David Laight
2012-09-11 1:07 ` Cong Wang [this message]
2012-09-10 20:32 ` David Miller
2012-09-11 1:19 ` Cong Wang
2012-09-11 1:42 ` David Miller
2012-09-11 8:39 ` Cong Wang
2012-09-10 12:48 ` [PATCH 3/3] fib6: remove some useless empty lines and comments Cong Wang
2012-09-10 20:33 ` David Miller
2012-09-11 1:09 ` Cong Wang
2012-09-10 20:31 ` [PATCH 1/3] ipv6: remove some useless RCU read lock David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347325657.30731.5.camel@cr0 \
--to=amwang@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).