From: "Christian Pössinger" <christian@poessinger.com>
To: "u9012063@gmail.com" <u9012063@gmail.com>
Cc: "Christian Pössinger" <christian@poessinger.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2] erspan: fix JSON output
Date: Wed, 7 Apr 2021 09:03:31 +0000 [thread overview]
Message-ID: <1347824917bc426c92a4aaebd41adb83@poessinger.com> (raw)
On Tue, Apr 6, 2021 at 9:28 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The format for erspan output is not valid JSON.
> The direction should be value and erspan_dir should be the key.
>
> Fixes: 289763626721 ("erspan: add erspan version II support")
> Cc: u9012063@gmail.com
> Reported-by: Christian Pössinger <christian@poessinger.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
I have rebuild iproute2 with the mentioned changes above but I can
not confirm this working. The behavior is still a missing value
for the JSON "erspan_dir" key.
--
Christian
next reply other threads:[~2021-04-07 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 9:03 Christian Pössinger [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-06 8:07 iproute2 ERSPAN version 2 JSON output shows valueless key Christian Pössinger
2021-04-06 16:28 ` [PATCH iproute2] erspan: fix JSON output Stephen Hemminger
2021-04-06 16:40 ` William Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347824917bc426c92a4aaebd41adb83@poessinger.com \
--to=christian@poessinger.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).