From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] tcp: use order-3 pages in tcp_sendmsg()
Date: Mon, 17 Sep 2012 19:02:06 +0200 [thread overview]
Message-ID: <1347901326.26523.149.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120917.121243.1665284878800146060.davem@davemloft.net>
On Mon, 2012-09-17 at 12:12 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Mon, 17 Sep 2012 09:49:04 +0200
>
> > 2) Use order-3 pages (or order-0 pages if page size is >= 32768)
>
> We could do with an audit to make sure drivers (and the stack in
> general) can handle SKB frags of length > PAGE_SIZE.
>
> I have no idea whether such problems might actually exist, but
> I can say it's a case that gets not so much testing.
I did a (quick) audit and it appears some NIC have limits like 16KB,
but they have helpers to support this, since some arches have
PAGE_SIZE=65536
ixgbe is an example, although it might need some tweaking if this code
path was not tested.
On the other hand, bnx2x has some special code to linearize too
fragmented skbs (in bnx2x_pkt_req_lin(), if skb_shinfo(skb)->nr_frags >=
10)
By the way I did more performance tests, and the speedup is more close
of 20 %
A driver already exports a dev->gso_max_size, dev->gso_max_segs, I guess
it could export a dev->max_seg_order (default to 0)
next prev parent reply other threads:[~2012-09-17 17:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 7:49 [RFC] tcp: use order-3 pages in tcp_sendmsg() Eric Dumazet
2012-09-17 16:12 ` David Miller
2012-09-17 17:02 ` Eric Dumazet [this message]
2012-09-17 17:04 ` Eric Dumazet
2012-09-17 17:07 ` David Miller
2012-09-19 15:14 ` Eric Dumazet
2012-09-19 17:28 ` Rick Jones
2012-09-19 17:55 ` Eric Dumazet
2012-09-19 17:56 ` David Miller
2012-09-19 19:04 ` Alexander Duyck
2012-09-19 20:18 ` Ben Hutchings
2012-09-19 22:20 ` Vijay Subramanian
2012-09-20 5:37 ` Eric Dumazet
2012-09-20 17:10 ` Rick Jones
2012-09-20 17:43 ` Eric Dumazet
2012-09-20 18:37 ` Yuchung Cheng
2012-09-20 19:40 ` David Miller
2012-09-20 20:06 ` Rick Jones
2012-09-20 20:25 ` Eric Dumazet
2012-09-21 15:48 ` Eric Dumazet
2012-09-21 16:27 ` David Miller
2012-09-21 16:51 ` Eric Dumazet
2012-09-21 17:04 ` David Miller
2012-09-21 17:11 ` Eric Dumazet
2012-09-23 12:47 ` Jan Engelhardt
2012-09-23 16:16 ` David Miller
2012-09-23 17:40 ` Jan Engelhardt
2012-09-23 18:13 ` Eric Dumazet
2012-09-23 18:27 ` David Miller
2012-09-20 21:39 ` Vijay Subramanian
2012-09-20 22:01 ` Rick Jones
2012-11-15 7:52 ` Yan, Zheng
2012-11-15 13:06 ` Eric Dumazet
2012-11-16 2:36 ` Yan, Zheng
2012-11-15 13:47 ` Eric Dumazet
2012-11-21 8:05 ` Yan, Zheng
2012-11-15 18:33 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347901326.26523.149.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox