* [PATCH] net/core: fix comment in skb_try_coalesce
@ 2012-09-19 2:53 roy.qing.li
2012-09-19 5:08 ` Eric Dumazet
2012-09-19 21:29 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: roy.qing.li @ 2012-09-19 2:53 UTC (permalink / raw)
To: netdev
From: Li RongQing <roy.qing.li@gmail.com>
It should be the skb which is not cloned
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
net/core/skbuff.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index fe00d12..354a4e4 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -3502,7 +3502,9 @@ bool skb_try_coalesce(struct sk_buff *to, struct sk_buff *from,
if (!skb_cloned(from))
skb_shinfo(from)->nr_frags = 0;
- /* if the skb is cloned this does nothing since we set nr_frags to 0 */
+ /* if the skb is not cloned this does nothing
+ * since we set nr_frags to 0.
+ */
for (i = 0; i < skb_shinfo(from)->nr_frags; i++)
skb_frag_ref(from, i);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/core: fix comment in skb_try_coalesce
2012-09-19 2:53 [PATCH] net/core: fix comment in skb_try_coalesce roy.qing.li
@ 2012-09-19 5:08 ` Eric Dumazet
2012-09-19 21:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2012-09-19 5:08 UTC (permalink / raw)
To: roy.qing.li; +Cc: netdev
On Wed, 2012-09-19 at 10:53 +0800, roy.qing.li@gmail.com wrote:
> From: Li RongQing <roy.qing.li@gmail.com>
>
> It should be the skb which is not cloned
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> ---
> net/core/skbuff.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index fe00d12..354a4e4 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -3502,7 +3502,9 @@ bool skb_try_coalesce(struct sk_buff *to, struct sk_buff *from,
> if (!skb_cloned(from))
> skb_shinfo(from)->nr_frags = 0;
>
> - /* if the skb is cloned this does nothing since we set nr_frags to 0 */
> + /* if the skb is not cloned this does nothing
> + * since we set nr_frags to 0.
> + */
> for (i = 0; i < skb_shinfo(from)->nr_frags; i++)
> skb_frag_ref(from, i);
>
Yes I saw that yesterday and was about to submit the same change (more
or less)
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/core: fix comment in skb_try_coalesce
2012-09-19 2:53 [PATCH] net/core: fix comment in skb_try_coalesce roy.qing.li
2012-09-19 5:08 ` Eric Dumazet
@ 2012-09-19 21:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-09-19 21:29 UTC (permalink / raw)
To: roy.qing.li; +Cc: netdev
From: roy.qing.li@gmail.com
Date: Wed, 19 Sep 2012 10:53:21 +0800
> From: Li RongQing <roy.qing.li@gmail.com>
>
> It should be the skb which is not cloned
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-19 21:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-19 2:53 [PATCH] net/core: fix comment in skb_try_coalesce roy.qing.li
2012-09-19 5:08 ` Eric Dumazet
2012-09-19 21:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).