From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [Patch net-next] l2tp: fix compile error when CONFIG_IPV6=m and CONFIG_L2TP=y
Date: Thu, 20 Sep 2012 15:36:54 +0800 [thread overview]
Message-ID: <1348126614.17345.8.camel@cr0> (raw)
In-Reply-To: <20120919.164403.1265757047954729748.davem@davemloft.net>
On Wed, 2012-09-19 at 16:44 -0400, David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Tue, 18 Sep 2012 13:54:02 +0800
>
> > When CONFIG_IPV6=m and CONFIG_L2TP=y, I got the following compile error:
> ...
> > This is due to l2tp uses symbols from IPV6, so when l2tp is
> > builtin, IPV6 has to be builtin too.
> >
> > Cc: David Miller <davem@davemloft.net>
> > Signed-off-by: Cong Wang <amwang@redhat.com>
>
> The correct way to express this is:
>
> depends on (IPV6 || IPV6=n)
>
> Which results in the KCONFIG option only being offers in modes
> compatible with the dependency. Using a 'select' doesn't work
> properly in these kinds of cases.
>
> Anyways, grep for that string to see how it is used in other similar
> situations.
>
Thanks for the hints! I will update this patch.
prev parent reply other threads:[~2012-09-20 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 5:54 [Patch net-next] l2tp: fix compile error when CONFIG_IPV6=m and CONFIG_L2TP=y Cong Wang
2012-09-19 20:44 ` David Miller
2012-09-20 7:36 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348126614.17345.8.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).