From: Eric Dumazet <eric.dumazet@gmail.com>
To: artem.bityutskiy@linux.intel.com
Cc: Eric Dumazet <edumazet@google.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: regression: tethering fails in 3.5 with iwlwifi
Date: Thu, 20 Sep 2012 15:22:02 +0200 [thread overview]
Message-ID: <1348147322.31352.69.camel@edumazet-glaptop> (raw)
In-Reply-To: <1348147353.2388.19.camel@sauron.fi.intel.com>
On Thu, 2012-09-20 at 16:22 +0300, Artem Bityutskiy wrote:
>
> OK, I've tried almost this (see below) and it solves my issue:
>
> diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
> index 965e6ec..7f079d0 100644
> --- a/net/mac80211/rx.c
> +++ b/net/mac80211/rx.c
> @@ -1798,9 +1798,13 @@ ieee80211_deliver_skb(struct ieee80211_rx_data *rx)
>
> if (skb) {
> /* deliver to local stack */
> - skb->protocol = eth_type_trans(skb, dev);
> - memset(skb->cb, 0, sizeof(skb->cb));
> - netif_receive_skb(skb);
> + if (pskb_may_pull(skb, 40)) {
> + skb->protocol = eth_type_trans(skb, dev);
> + memset(skb->cb, 0, sizeof(skb->cb));
> + netif_receive_skb(skb);
> + } else {
> + kfree_skb(skb);
> + }
> }
> }
>
OK but you cant do that, or small frames will be dropped.
Anyway its a hack, we should find the buggy layer.
You could use dropwatch (drop_monitor) to check where frame is dropped.
modprobe drop_monitor
dropwatch -l kas
next prev parent reply other threads:[~2012-09-20 13:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1347361823.26457.3.camel@sauron.fi.intel.com>
[not found] ` <1DC40B07CD6EC041A66726C271A73AE6195AE9C8@IRSMSX102.ger.corp.intel.com>
[not found] ` <1347631355.5263.19.camel@sauron.fi.intel.com>
[not found] ` <1347640763.5263.24.camel@sauron.fi.intel.com>
[not found] ` <1347892887.7112.9.camel@sauron.fi.intel.com>
[not found] ` <1348142775.2388.10.camel@sauron.fi.intel.com>
2012-09-20 12:35 ` regression: tethering fails in 3.5 with iwlwifi Johannes Berg
[not found] ` <1348144524.4161.26.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-09-20 12:40 ` Eric Dumazet
2012-09-20 12:45 ` Eric Dumazet
2012-09-20 12:46 ` Eric Dumazet
[not found] ` <CANn89iLnv2kWLd_hTpMXjMJ=r+hOvb2q2Oy6L-s5+6SzqxYvjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-20 12:50 ` Johannes Berg
2012-09-20 12:47 ` Johannes Berg
[not found] ` <1348145269.4161.28.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-09-20 12:48 ` Eric Dumazet
2012-09-20 12:50 ` Johannes Berg
[not found] ` <1348145450.4161.31.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-09-20 12:51 ` Eric Dumazet
[not found] ` <CANn89iLudX29yU8ziNyN+8gN3b2L55L9m5p6ob_wnfZ3fp_TDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-20 12:54 ` Johannes Berg
2012-09-20 12:51 ` Johannes Berg
[not found] ` <CANn89iKStHAwVZtpgQMzEpByGYG2FKpjSQsJFT-9qQmjw+KJ8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-20 12:58 ` Artem Bityutskiy
[not found] ` <1348145936.2388.18.camel-Bxnoe/o8FG+Ef9UqXRslZEEOCMrvLtNR@public.gmane.org>
2012-09-20 13:04 ` Eric Dumazet
[not found] ` <CANn89i+9Th=xVgDgoy7tHwKtLNpOC8rgJkA09nQ1Yf0zvqBw6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-20 13:15 ` Eric Dumazet
2012-09-20 13:22 ` Artem Bityutskiy
2012-09-20 13:22 ` Eric Dumazet [this message]
2012-09-20 14:25 ` Eric Dumazet
2012-09-21 17:24 ` David Miller
[not found] ` <CANn89iJkXrZPB14KU8xA-Dn8_n=H3J4-R60BTZFV+STF9_ASdA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-20 12:47 ` Johannes Berg
2013-03-21 19:34 ` Johannes Berg
2013-03-21 21:24 ` David Miller
[not found] ` <1363894451.8181.4.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2013-03-22 7:01 ` Artem Bityutskiy
2013-03-23 15:45 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348147322.31352.69.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox