From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: gregkh@linuxfoundation.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next] net1080: Neaten netdev_dbg use
Date: Thu, 20 Sep 2012 17:10:23 -0700 [thread overview]
Message-ID: <1348186223.2134.1.camel@joe2Laptop> (raw)
In-Reply-To: <20120920.175335.1128494030737237412.davem@davemloft.net>
Remove unnecessary temporary variable and #ifdef DEBUG block.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/usb/net1080.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/usb/net1080.c b/drivers/net/usb/net1080.c
index 29e06e1..c062a3e 100644
--- a/drivers/net/usb/net1080.c
+++ b/drivers/net/usb/net1080.c
@@ -417,12 +417,9 @@ static int net1080_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
u16 hdr_len, packet_len;
if (!(skb->len & 0x01)) {
-#ifdef DEBUG
- struct net_device *net = dev->net;
netdev_dbg(dev->net, "rx framesize %d range %d..%d mtu %d\n",
- skb->len, net->hard_header_len, dev->hard_mtu,
- net->mtu);
-#endif
+ skb->len, dev->net->hard_header_len, dev->hard_mtu,
+ dev->net->mtu);
dev->net->stats.rx_frame_errors++;
nc_ensure_sync(dev);
return 0;
next prev parent reply other threads:[~2012-09-21 0:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 17:13 [PATCH] USB: remove dbg() usage in USB networking drivers Greg Kroah-Hartman
2012-09-19 17:53 ` Joe Perches
2012-09-19 19:35 ` Greg Kroah-Hartman
2012-09-19 19:46 ` [PATCH v2] " Greg Kroah-Hartman
2012-09-20 10:07 ` Joe Perches
2012-09-20 10:30 ` Greg Kroah-Hartman
2012-09-20 21:53 ` David Miller
2012-09-21 0:10 ` Joe Perches [this message]
2012-09-21 2:06 ` [PATCH net-next] net1080: Neaten netdev_dbg use David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348186223.2134.1.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).