From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] filter: add XOR instruction for use with X/K Date: Mon, 24 Sep 2012 15:43:48 +0200 Message-ID: <1348494228.26828.784.camel@edumazet-glaptop> References: <20120924122359.GB25156@thinkbox> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org To: Daniel Borkmann Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:43972 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753931Ab2IXNnx (ORCPT ); Mon, 24 Sep 2012 09:43:53 -0400 Received: by bkcjk13 with SMTP id jk13so917051bkc.19 for ; Mon, 24 Sep 2012 06:43:52 -0700 (PDT) In-Reply-To: <20120924122359.GB25156@thinkbox> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2012-09-24 at 14:23 +0200, Daniel Borkmann wrote: > BPF_S_ANC_ALU_XOR_X has been added a while ago, but as an 'ancillary' > operation that is invoked through a negative offset in K within BPF > load operations. Since BPF_MOD has recently been added, BPF_XOR should > also be part of the common ALU operations. Removing BPF_S_ANC_ALU_XOR_X > might not be an option since this is exposed to user space. Please note we dont expose BPF_S_ANC_ALU_XOR_X to user space. We expose SKF_AD_ALU_XOR_X instead. But it seems easier to leave it to keep this patch small (not touching various JIT implementations, even if followup are welcomed) Acked-by: Eric Dumazet