From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: flow control handling in network driver Date: Wed, 26 Sep 2012 15:49:49 +0200 Message-ID: <1348667389.10741.34.camel@deadeye.wl.decadent.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: To: Rayagond K Return-path: Received: from webmail.solarflare.com ([12.187.104.25]:60261 "EHLO ocex02.SolarFlarecom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756555Ab2IZNtx (ORCPT ); Wed, 26 Sep 2012 09:49:53 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2012-09-26 at 14:48 +0530, Rayagond K wrote: > Hi All, > > What is the use of two macros SUPPORTED_Pause and SUPPORTED_Asym_Pause > which are defined in ethtool.h file. > > I have seen amny driver in lxr using above macros, for example tg3 > driver - uses these macros to advertise the phy capabilities. > > Flow control is MAC feature not PHY, hence when can one use above > macros and what is the use of it. Should we use these macros to > implement flow control in Ethernet driver ? Ethernet autonegotiation includes flow control as well as speed and duplex (and some other parameters). Any device that supports Ethernet flow control and autonegotiation should set the supported flags accordingly and check the advertised flags when programming the PHY for autonegotiation. (This is complicated a bit by the separate ethtool commands for flow control.) Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.