Re: [PATCH] vlan: Make it possible to add vlan with id 4095

Jan Engelhardt
2012-11-12T18:42:13Z

On Friday 2012-09-28 19:44, David Miller wrote:

>From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
>Date: Fri, 28 Sep 2012 15:32:58 +0300
>
>> vconfig help tells that vlan_id should be 0-4095, but fails
>> with 4095.
>>
>> There is an off-by-one bug while evaluating vlan_id.
>> Fix it by evaluating against count(4096), not mask(0x0fff = 4095).
>>
>> Signed-off-by: Paulius Zaleckas <paulius.zaleckas@gmail.com>
>
>Awesome, we don't need VXVLAN any more after this fix.

You mean because the special 0xfff value could indicate "here's more
headers"? Sounds like a plan.