* [PATCH] net: ethernet: davinci_cpdma: decrease the desc count when cleaning up the remaining packets
@ 2012-10-02 2:42 Tao Hou
2012-10-03 2:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tao Hou @ 2012-10-02 2:42 UTC (permalink / raw)
To: David S. Miller, netdev; +Cc: linux-kernel, Tao Hou
chan->count is used by rx channel. If the desc count is not updated by
the clean up loop in cpdma_chan_stop, the value written to the rxfree
register in cpdma_chan_start will be incorrect.
Signed-off-by: Tao Hou <hotforest@gmail.com>
---
drivers/net/ethernet/ti/davinci_cpdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index d15c888..4995673 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -863,6 +863,7 @@ int cpdma_chan_stop(struct cpdma_chan *chan)
next_dma = desc_read(desc, hw_next);
chan->head = desc_from_phys(pool, next_dma);
+ chan->count--;
chan->stats.teardown_dequeue++;
/* issue callback without locks held */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: davinci_cpdma: decrease the desc count when cleaning up the remaining packets
2012-10-02 2:42 [PATCH] net: ethernet: davinci_cpdma: decrease the desc count when cleaning up the remaining packets Tao Hou
@ 2012-10-03 2:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-10-03 2:35 UTC (permalink / raw)
To: hotforest; +Cc: netdev, linux-kernel
From: Tao Hou <hotforest@gmail.com>
Date: Tue, 2 Oct 2012 10:42:43 +0800
> chan->count is used by rx channel. If the desc count is not updated by
> the clean up loop in cpdma_chan_stop, the value written to the rxfree
> register in cpdma_chan_start will be incorrect.
>
> Signed-off-by: Tao Hou <hotforest@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-03 2:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-02 2:42 [PATCH] net: ethernet: davinci_cpdma: decrease the desc count when cleaning up the remaining packets Tao Hou
2012-10-03 2:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).