netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Senna Tschudin <peter.senna@gmail.com>
To: mlindner@marvell.com
Cc: kernel-janitors@vger.kernel.org, shemminger@vyatta.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code
Date: Wed,  3 Oct 2012 18:18:10 +0200	[thread overview]
Message-ID: <1349281090-10013-20-git-send-email-peter.senna@gmail.com> (raw)

From: Peter Senna Tschudin <peter.senna@gmail.com>

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>

---
 drivers/net/ethernet/marvell/skge.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index 5a30bf8..91836b5 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -3945,8 +3945,10 @@ static int __devinit skge_probe(struct pci_dev *pdev,
 		skge_board_name(hw), hw->chip_rev);
 
 	dev = skge_devinit(hw, 0, using_dac);
-	if (!dev)
+	if (!dev) {
+		err = -ENOMEM;
 		goto err_out_led_off;
+	}
 
 	/* Some motherboards are broken and has zero in ROM. */
 	if (!is_valid_ether_addr(dev->dev_addr))

             reply	other threads:[~2012-10-03 16:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-03 16:18 Peter Senna Tschudin [this message]
2012-10-03 16:25 ` [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code Stephen Hemminger
2012-10-03 18:48   ` David Miller
2012-10-04  9:05   ` Peter Senna Tschudin
2012-10-04 14:44     ` Stephen Hemminger
2012-10-04 17:32       ` Peter Senna Tschudin
2012-10-04 17:40         ` Stephen Hemminger
2012-10-04 18:13           ` Peter Senna Tschudin
2012-10-04 18:23         ` David Miller
2012-10-04 18:49           ` Peter Senna Tschudin
2012-10-04 18:54             ` David Miller
2012-10-05  0:09               ` Joe Perches
2012-10-05  5:22                 ` Julia Lawall
2012-10-05  7:36                   ` Joe Perches
2012-10-05  8:02                     ` Dan Carpenter
2012-10-05  8:08                     ` Julia Lawall
2012-10-10 17:08                       ` Peter Senna Tschudin
2012-10-10 17:40                         ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349281090-10013-20-git-send-email-peter.senna@gmail.com \
    --to=peter.senna@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlindner@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).