From: Eric Dumazet <eric.dumazet@gmail.com>
To: Erik Hugne <erik.hugne@ericsson.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jon Maloy <jon.maloy@ericsson.com>,
"ying.xue@windriver.com" <ying.xue@windriver.com>,
"paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>
Subject: Re: [PATCH] tipc: flow control should not account for sk_rcvbuf
Date: Thu, 04 Oct 2012 12:26:00 +0200 [thread overview]
Message-ID: <1349346360.16011.36.camel@edumazet-glaptop> (raw)
In-Reply-To: <506D5DEF.9050700@ericsson.com>
On Thu, 2012-10-04 at 11:59 +0200, Erik Hugne wrote:
> > What guarantee do we have this cannot use all kernel memory ?
> >
> > If sk->sk_rcvbuf is not an acceptable limit here, you must use a
> > different limit, but not infinity.
> >
> There is an implicit limit on how much data that can be buffered on each
> socket, controlled by TIPC_FLOW_CONTROL_WIN.
>
> This limit is:
> TIPC_FLOW_CONTROL_WIN * 2 * TIPC_MAX_USER_MSG_SIZE
And this limit is tested _before_ queueing to backlog if socket is owned
by the user ?
You'll have to demonstrate this in the changelog.
Again, I dont think this patch is safe, we need an explicit limit.
next prev parent reply other threads:[~2012-10-04 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 9:14 [PATCH] tipc: flow control should not account for sk_rcvbuf erik.hugne
2012-10-04 9:21 ` Eric Dumazet
2012-10-04 9:59 ` Erik Hugne
2012-10-04 10:26 ` Eric Dumazet [this message]
2012-10-04 12:12 ` Erik Hugne
2012-10-04 13:55 ` Eric Dumazet
2012-10-04 15:00 ` [PATCH v2] tipc: prevent dropped connections due to rcvbuf overflow erik.hugne
2012-10-04 19:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349346360.16011.36.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox