From: Ben Hutchings <bhutchings@solarflare.com>
To: Gao feng <gaofeng@cn.fujitsu.com>
Cc: <davem@davemloft.net>, <eric.dumazet@gmail.com>,
<steffen.klassert@secunet.com>, <netfilter-devel@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-crypto@vger.kernel.org>, <pablo@netfilter.org>,
<stephen.hemminger@vyatta.com>, <jengelh@inai.de>
Subject: Re: [patch v3 01/11] netlink: add reference of module in netlink_dump_start
Date: Thu, 4 Oct 2012 16:41:42 +0100 [thread overview]
Message-ID: <1349365302.2817.1.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <1349325689-16104-1-git-send-email-gaofeng@cn.fujitsu.com>
On Thu, 2012-10-04 at 12:41 +0800, Gao feng wrote:
> I get a panic when I use ss -a and rmmod inet_diag at the
> same time.
>
> it's because netlink_dump use inet_diag_dump witch function
> belongs to module inet_diag.
>
> I search the codes and find many modules have the same problem.
> We need add reference of the module witch the cb->dump belongs
> to.
>
> Thanks for all help from Stephen,Jan,Eric,Steffen and Pablo.
>
> Change From v2:
>
> delete netlink_dump_done,and call module_put in netlink_dump
> and netlink_sock_destruct.
[...]
> @@ -1794,19 +1798,28 @@ int netlink_dump_start(struct sock *ssk, struct sk_buff *skb,
> return -ECONNREFUSED;
> }
> nlk = nlk_sk(sk);
> - /* A dump is in progress... */
> +
> mutex_lock(nlk->cb_mutex);
> + /* A dump is in progress... */
> if (nlk->cb) {
> mutex_unlock(nlk->cb_mutex);
> netlink_destroy_callback(cb);
> - sock_put(sk);
> - return -EBUSY;
> + ret = -EBUSY;
> + goto out;
> }
> + /* add reference of module witch cb->dump belong to */
[...]
'which' not 'witch' :-)
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-10-04 15:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 4:41 [patch v3 01/11] netlink: add reference of module in netlink_dump_start Gao feng
2012-10-04 4:41 ` [patch v3 02/11] inet_diag: pass inet_diag module to netlink_dump_start Gao feng
2012-10-04 5:08 ` Eric Dumazet
2012-10-04 8:03 ` Gao feng
2012-10-04 4:41 ` [patch v3 04/11] nf_conntrack_netlink: pass nf_conntrack_netlink " Gao feng
2012-10-04 4:41 ` [patch v3 05/11] nfnetlink_acct: pass nfnetlink_acct " Gao feng
[not found] ` <1349325689-16104-1-git-send-email-gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-10-04 4:41 ` [patch v3 03/11] unix_diag: pass unix_diag " Gao feng
2012-10-04 4:41 ` [patch v3 06/11] nfnetlink_cthelper: pass nfnetlink_cthelper " Gao feng
2012-10-04 4:41 ` [patch v3 07/11] nfnetlink_cttimeout: pass nfnetlink_cttimeout " Gao feng
2012-10-04 4:41 ` [patch v3 11/11] infiniband: pass rdma_cm " Gao feng
2012-10-04 4:41 ` [patch v3 08/11] crypto: pass crypto_user " Gao feng
2012-10-04 4:41 ` [patch v3 09/11] xfrm: pass xfrm_user " Gao feng
2012-10-04 4:41 ` [patch v3 10/11] ipset: pass ipset " Gao feng
2012-10-04 15:41 ` Ben Hutchings [this message]
2012-10-05 0:50 ` [patch v3 01/11] netlink: add reference of module in netlink_dump_start Gao feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349365302.2817.1.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=jengelh@inai.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=steffen.klassert@secunet.com \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox