From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Jesse Gross <jesse@nicira.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [RFC] vxlan: use ether header as fallback hash
Date: Thu, 04 Oct 2012 19:07:56 +0200 [thread overview]
Message-ID: <1349370476.16011.84.camel@edumazet-glaptop> (raw)
In-Reply-To: <20121004094333.748158e2@nehalam.linuxnetplumber.net>
On Thu, 2012-10-04 at 09:43 -0700, Stephen Hemminger wrote:
> On Thu, 4 Oct 2012 09:27:14 -0700
> Jesse Gross <jesse@nicira.com> wrote:
> > > +static u16 vxlan_flow_hash(struct sk_buff *skb)
> > > +{
> > > + u16 hash = skb_get_rxhash(skb);
> > > +
> > > + if (!hash)
> > > + hash = jhash(skb->data, 3, skb->protocol);
> >
> > Shouldn't this be jhash2 for words?
>
> No. for a couple of reasons. First, the ethernet header may not be aligned.
> Second we want to get source/destination and type. The source/destination
> is 12 bytes (3 words) and the ether type is already in skb->protocol.
jhash(skb->data, 12, initval)
prev parent reply other threads:[~2012-10-04 17:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121001223232.566037595@vyatta.com>
2012-10-01 22:32 ` [PATCH 1/3] netlink: add attributes to fdb interface Stephen Hemminger
2012-10-01 22:40 ` David Miller
2012-10-01 22:32 ` [PATCH 2/3] igmp: export symbol ip_mc_leave_group Stephen Hemminger
2012-10-01 22:40 ` David Miller
2012-10-01 22:32 ` [PATCH 3/3] vxlan: virtual extensible lan Stephen Hemminger
2012-10-01 22:40 ` David Miller
2012-10-04 1:54 ` Jesse Gross
2012-10-04 4:02 ` Stephen Hemminger
2012-10-04 6:34 ` Eric Dumazet
2012-10-04 15:12 ` Stephen Hemminger
2012-10-04 16:25 ` Jesse Gross
2012-10-04 4:39 ` [RFC] vxlan: use ether header as fallback hash Stephen Hemminger
2012-10-04 4:57 ` Eric Dumazet
2012-10-04 5:06 ` Stephen Hemminger
2012-10-04 16:27 ` Jesse Gross
2012-10-04 16:43 ` Stephen Hemminger
2012-10-04 17:06 ` Jesse Gross
2012-10-04 17:07 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349370476.16011.84.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox