Re: [PATCH] net: remove skb recycling

David Miller
2012-10-07T04:41:11Z

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 05 Oct 2012 18:23:55 +0200

> From: Eric Dumazet <edumazet@google.com>
>
> Over time, skb recycling infrastructure got litle interest and
> many bugs. Generic rx path skb allocation is now using page
> fragments for efficient GRO / TCP coalescing, and recyling
> a tx skb for rx path is not worth the pain.
>
> Last identified bug is that fat skbs can be recycled
> and it can endup using high order pages after few iterations.
>
> With help from Maxime Bizon, who pointed out that commit
> 87151b8689d (net: allow pskb_expand_head() to get maximum tailroom)
> introduced this regression for recycled skbs.
>
> Instead of fixing this bug, lets remove skb recycling.
>
> Drivers wanting really hot skbs should use build_skb() anyway,
> to allocate/populate sk_buff right before netif_receive_skb()
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Maxime Bizon <mbizon@freebox.fr>

Applied, thanks Eric.