* [PATCH] ath/ath9k/ar9003_eeprom.c: Remove unnecessary semicolon
@ 2012-09-30 19:21 Peter Senna Tschudin
[not found] ` <1349032870-4780-1-git-send-email-peter.senna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-30 20:56 ` [PATCH V2] ath/ath9k/ar9003_eeprom.c: Remove semicolon after if Peter Senna Tschudin
0 siblings, 2 replies; 5+ messages in thread
From: Peter Senna Tschudin @ 2012-09-30 19:21 UTC (permalink / raw)
To: mcgrof
Cc: jouni, vthiagar, senthilb, linville, linux-wireless, ath9k-devel,
netdev, kernel-janitors, Peter Senna Tschudin
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r1@
position p;
@@
if (...);@p
@script:python@
p0 << r1.p;
@@
// Emacs org-mode output
cocci.print_main("", p0)
cocci.print_secs("", p0)
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
index 5bbe505..189aeb2 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
@@ -2989,7 +2989,7 @@ static u32 ath9k_hw_ar9300_get_eeprom(struct ath_hw *ah,
case EEP_PAPRD:
if (AR_SREV_9462(ah))
return false;
- if (!ah->config.enable_paprd);
+ if (!ah->config.enable_paprd)
return false;
return !!(pBase->featureEnable & BIT(5));
case EEP_CHAIN_MASK_REDUCE:
--
1.7.11.4
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <1349032870-4780-1-git-send-email-peter.senna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] ath/ath9k/ar9003_eeprom.c: Remove unnecessary semicolon
[not found] ` <1349032870-4780-1-git-send-email-peter.senna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2012-09-30 19:34 ` Johannes Berg
0 siblings, 0 replies; 5+ messages in thread
From: Johannes Berg @ 2012-09-30 19:34 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: mcgrof-A+ZNKFmMK5xy9aJCnZT0Uw, jouni-A+ZNKFmMK5xy9aJCnZT0Uw,
vthiagar-A+ZNKFmMK5xy9aJCnZT0Uw, senthilb-A+ZNKFmMK5xy9aJCnZT0Uw,
linville-2XuSBdqkA4R54TAoqtyWWQ,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
ath9k-devel-xDcbHBWguxHbcTqmT+pZeQ, netdev-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Sun, 2012-09-30 at 21:21 +0200, Peter Senna Tschudin wrote:
> - if (!ah->config.enable_paprd);
> + if (!ah->config.enable_paprd)
> return false;
That's not an "unnecessary semicolon", it's a pretty strange bug :)
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V2] ath/ath9k/ar9003_eeprom.c: Remove semicolon after if
2012-09-30 19:21 [PATCH] ath/ath9k/ar9003_eeprom.c: Remove unnecessary semicolon Peter Senna Tschudin
[not found] ` <1349032870-4780-1-git-send-email-peter.senna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2012-09-30 20:56 ` Peter Senna Tschudin
2012-10-10 16:38 ` [PATCH V3] " Peter Senna Tschudin
1 sibling, 1 reply; 5+ messages in thread
From: Peter Senna Tschudin @ 2012-09-30 20:56 UTC (permalink / raw)
To: mcgrof
Cc: vthiagar, kernel-janitors, jouni, Peter Senna Tschudin,
linux-wireless, linville, linux-kernel, ath9k-devel, netdev,
senthilb
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r1@
position p;
@@
if (...);@p
@script:python@
p0 << r1.p;
@@
// Emacs org-mode output
cocci.print_main("", p0)
cocci.print_secs("", p0)
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
NOTE: This patch changes the semantics.
Changes from V1:
Commit message
Added a note about semantics change
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
index 5bbe505..189aeb2 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
@@ -2989,7 +2989,7 @@ static u32 ath9k_hw_ar9300_get_eeprom(struct ath_hw *ah,
case EEP_PAPRD:
if (AR_SREV_9462(ah))
return false;
- if (!ah->config.enable_paprd);
+ if (!ah->config.enable_paprd)
return false;
return !!(pBase->featureEnable & BIT(5));
case EEP_CHAIN_MASK_REDUCE:
--
1.7.11.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH V3] ath/ath9k/ar9003_eeprom.c: Remove semicolon after if
2012-09-30 20:56 ` [PATCH V2] ath/ath9k/ar9003_eeprom.c: Remove semicolon after if Peter Senna Tschudin
@ 2012-10-10 16:38 ` Peter Senna Tschudin
2012-10-10 18:22 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Peter Senna Tschudin @ 2012-10-10 16:38 UTC (permalink / raw)
To: mcgrof
Cc: jouni, vthiagar, senthilb, linville, linux-wireless, ath9k-devel,
netdev, linux-kernel, kernel-janitors, Peter Senna Tschudin
This patch remove a semicolon after if(...) that is preventing the
error check to work correctly. Removing this semicolon will change the
code behavior, but this is intended.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r1@
position p;
@@
if (...);@p
@script:python@
p0 << r1.p;
@@
// Emacs org-mode output
cocci.print_main("", p0)
cocci.print_secs("", p0)
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
NOTE: This patch changes the semantics.
Changes from V1:
Commit message
Added a note about semantics change
Changes from V2:
Commit message
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
index 5bbe505..189aeb2 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
@@ -2989,7 +2989,7 @@ static u32 ath9k_hw_ar9300_get_eeprom(struct ath_hw *ah,
case EEP_PAPRD:
if (AR_SREV_9462(ah))
return false;
- if (!ah->config.enable_paprd);
+ if (!ah->config.enable_paprd)
return false;
return !!(pBase->featureEnable & BIT(5));
case EEP_CHAIN_MASK_REDUCE:
--
1.7.11.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH V3] ath/ath9k/ar9003_eeprom.c: Remove semicolon after if
2012-10-10 16:38 ` [PATCH V3] " Peter Senna Tschudin
@ 2012-10-10 18:22 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2012-10-10 18:22 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: mcgrof, jouni, vthiagar, senthilb, linville, linux-wireless,
ath9k-devel, netdev, linux-kernel, kernel-janitors
On Wed, 2012-10-10 at 18:38 +0200, Peter Senna Tschudin wrote:
> This patch remove a semicolon after if(...) that is preventing the
> error check to work correctly. Removing this semicolon will change the
> code behavior, but this is intended.
>
> The semantic patch that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r1@
> position p;
> @@
> if (...);@p
this semantic patch would be a lot less tedious to
inspect the results if it excluded else after the
semicolon.
I've used perl for more or less the same output.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-10 18:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-30 19:21 [PATCH] ath/ath9k/ar9003_eeprom.c: Remove unnecessary semicolon Peter Senna Tschudin
[not found] ` <1349032870-4780-1-git-send-email-peter.senna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-30 19:34 ` Johannes Berg
2012-09-30 20:56 ` [PATCH V2] ath/ath9k/ar9003_eeprom.c: Remove semicolon after if Peter Senna Tschudin
2012-10-10 16:38 ` [PATCH V3] " Peter Senna Tschudin
2012-10-10 18:22 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).