From: Joe Perches <joe@perches.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Brian Haley <brian.haley@hp.com>
Subject: [PATCH net-next? V2] pktgen: Use simpler test for non-zero ipv6 address
Date: Wed, 10 Oct 2012 12:23:25 -0700 [thread overview]
Message-ID: <1349897005.2035.24.camel@joe-AO722> (raw)
In-Reply-To: <1349895710.21172.7235.camel@edumazet-glaptop>
Reduces object size and should be slightly faster.
allyesconfig:
$ size net/core/pktgen.o*
text data bss dec hex filename
52284 4321 11840 68445 10b5d net/core/pktgen.o.new
52310 4293 11848 68451 10b63 net/core/pktgen.o.old
Signed-off-by: Joe Perches <joe@perches.com>
---
> What about ipv6_addr_any() ?
That's better I guess.
I forgot about it and didn't see it.
I saw the IPV6_ADDR_ANY type tests and
didn't look further.
Anyway, it's odd that it generates slightly larger code
than the original patch's direct tests in 32bit with
gcc 4.7.2. Perhaps an interesting lack of optimization?
cheers, Joe
net/core/pktgen.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 148e73d..a811a7d 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -2422,11 +2422,7 @@ static void mod_cur_headers(struct pktgen_dev *pkt_dev)
}
} else { /* IPV6 * */
- if (pkt_dev->min_in6_daddr.s6_addr32[0] == 0 &&
- pkt_dev->min_in6_daddr.s6_addr32[1] == 0 &&
- pkt_dev->min_in6_daddr.s6_addr32[2] == 0 &&
- pkt_dev->min_in6_daddr.s6_addr32[3] == 0) ;
- else {
+ if (!ipv6_addr_any(&pkt_dev->min_in6_daddr)) {
int i;
/* Only random destinations yet */
next prev parent reply other threads:[~2012-10-10 19:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 18:42 [PATCH net-next?] pktgen: Use simpler test for non-zero ipv6 address Joe Perches
2012-10-10 18:59 ` Brian Haley
2012-10-10 19:01 ` Eric Dumazet
2012-10-10 19:23 ` Joe Perches [this message]
2012-10-10 19:38 ` [RFC net-next] treewide: s/ipv4_is_<foo>()/ipv4_addr_<foo>/ Joe Perches
2012-10-11 0:56 ` [RFC net-next] treewide: s/is_<foo>_ether_addr/eth_addr_<foo> Joe Perches
2012-10-11 8:11 ` [RFC net-next] treewide: s/ipv4_is_<foo>()/ipv4_addr_<foo>/ David Laight
2012-10-11 8:28 ` Joe Perches
2012-10-11 2:15 ` [PATCH net-next? V2] pktgen: Use simpler test for non-zero ipv6 address Cong Wang
2012-10-11 19:20 ` David Miller
2012-10-11 8:08 ` [PATCH net-next?] " David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349897005.2035.24.camel@joe-AO722 \
--to=joe@perches.com \
--cc=brian.haley@hp.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox