public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Niels Baggesen <nba@users.sourceforge.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Ip6{In,Out}BcastPkts statistics missing from /proc/net/snmp6
Date: Fri, 12 Oct 2012 08:30:02 +0200	[thread overview]
Message-ID: <1350023402.21172.10776.camel@edumazet-glaptop> (raw)
In-Reply-To: <S1754091Ab2JLF5l/20121012055741Z+350@vger.kernel.org>

On Fri, 2012-10-12 at 01:57 -0400, Niels Baggesen wrote:
> The subject line says it all:
> 
> Ip6{In,Out}BcastPkts statistics missing from /proc/net/snmp6
> 
> Signed-off-by: Niels Baggesen <nba@users.sourceforge.net>
> 
> 
> --- net/ipv6/proc.c.orig    2012-10-01 12:52:09.452543199 +0200
> +++ net/ipv6/proc.c    2012-10-01 12:53:19.794660628 +0200
> @@ -90,6 +90,8 @@
>       SNMP_MIB_ITEM("Ip6OutMcastOctets", IPSTATS_MIB_OUTMCASTOCTETS),
>       SNMP_MIB_ITEM("Ip6InBcastOctets", IPSTATS_MIB_INBCASTOCTETS),
>       SNMP_MIB_ITEM("Ip6OutBcastOctets", IPSTATS_MIB_OUTBCASTOCTETS),
> +     SNMP_MIB_ITEM("Ip6InBcastPkts", IPSTATS_MIB_INBCASTPKTS),
> +     SNMP_MIB_ITEM("Ip6OutBcastPkts", IPSTATS_MIB_OUTBCASTPKTS),
>       SNMP_MIB_SENTINEL
>   };
> 
> /Niels
> 

And does it give useful information ?

As far as I know, IPv6 doesnt increment these counters, but I might be
wrong.

       reply	other threads:[~2012-10-12  6:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <S1754091Ab2JLF5l/20121012055741Z+350@vger.kernel.org>
2012-10-12  6:30 ` Eric Dumazet [this message]
2012-10-12  5:57 [PATCH] Ip6{In,Out}BcastPkts statistics missing from /proc/net/snmp6 Niels Baggesen
2012-10-12  6:26 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350023402.21172.10776.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=nba@users.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox