From: Rob Herring <robherring2@gmail.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: jonathan@jonmasters.org, eric.dumazet@gmail.com,
Mark Langsdorf <mark.langsdorf@calxeda.com>,
Rob Herring <rob.herring@calxeda.com>
Subject: [PATCH 4/6] net: calxedaxgmac: drop some unnecessary register writes
Date: Fri, 12 Oct 2012 10:15:06 -0500 [thread overview]
Message-ID: <1350054908-30646-5-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1350054908-30646-1-git-send-email-robherring2@gmail.com>
From: Rob Herring <rob.herring@calxeda.com>
The interrupts have already been cleared, so we don't need to clear them
again. Also, we could miss interrupts if they are cleared, but we don't
process the packet.
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
drivers/net/ethernet/calxeda/xgmac.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
index 117839e..4a1a06a 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -846,9 +846,6 @@ static void xgmac_free_dma_desc_rings(struct xgmac_priv *priv)
static void xgmac_tx_complete(struct xgmac_priv *priv)
{
int i;
- void __iomem *ioaddr = priv->base;
-
- writel(DMA_STATUS_TU | DMA_STATUS_NIS, ioaddr + XGMAC_DMA_STATUS);
while (dma_ring_cnt(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ)) {
unsigned int entry = priv->tx_tail;
@@ -1139,9 +1136,6 @@ static int xgmac_rx(struct xgmac_priv *priv, int limit)
struct sk_buff *skb;
int frame_len;
- writel(DMA_STATUS_RI | DMA_STATUS_NIS,
- priv->base + XGMAC_DMA_STATUS);
-
entry = priv->rx_tail;
p = priv->dma_rx + entry;
if (desc_get_owner(p))
--
1.7.9.5
next prev parent reply other threads:[~2012-10-12 15:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 15:15 [PATCH 0/6] Calxeda xgmac performance fixes Rob Herring
2012-10-12 15:15 ` [PATCH 1/6] net: calxedaxgmac: enable operate on 2nd frame mode Rob Herring
2012-10-12 15:15 ` [PATCH 2/6] net: calxedaxgmac: remove explicit rx dma buffer polling Rob Herring
2012-10-12 15:15 ` [PATCH 3/6] net: calxedaxgmac: use relaxed i/o accessors in rx and tx paths Rob Herring
2012-10-12 15:15 ` Rob Herring [this message]
2012-10-12 15:15 ` [PATCH 5/6] net: calxedaxgmac: rework transmit ring handling Rob Herring
2012-10-12 16:28 ` Ben Hutchings
2012-10-12 17:01 ` Rob Herring
2012-10-12 18:04 ` [PATCH v2] " Rob Herring
2012-10-12 18:30 ` Eric Dumazet
2012-10-12 20:21 ` Rob Herring
2012-10-12 15:15 ` [PATCH 6/6] net: calxedaxgmac: ip align receive buffers Rob Herring
2012-10-29 17:52 ` [PATCH 0/6] Calxeda xgmac performance fixes Rob Herring
2012-10-29 18:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350054908-30646-5-git-send-email-robherring2@gmail.com \
--to=robherring2@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=jonathan@jonmasters.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@calxeda.com \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).