From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: [PATCH 1/5] xen-netfront: handle backend CLOSED without CLOSING Date: Thu, 18 Oct 2012 11:03:34 +0100 Message-ID: <1350554618-14582-1-git-send-email-david.vrabel@citrix.com> References: <507FD39F.4060601@citrix.com> Mime-Version: 1.0 Content-Type: text/plain Cc: "David Vrabel" , Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" To: xen-devel@lists.xen.org Return-path: In-Reply-To: <507FD39F.4060601@citrix.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: David Vrabel Backend drivers shouldn't transistion to CLOSED unless the frontend is CLOSED. If a backend does transition to CLOSED too soon then the frontend may not see the CLOSING state and will not properly shutdown. So, treat an unexpected backend CLOSED state the same as CLOSING. Signed-off-by: David Vrabel Acked-by: Konrad Rzeszutek Wilk --- Cc: netdev@vger.kernel.org Cc: "David S. Miller" --- drivers/net/xen-netfront.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index caa0110..40cde51 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1701,7 +1701,6 @@ static void netback_changed(struct xenbus_device *dev, case XenbusStateReconfiguring: case XenbusStateReconfigured: case XenbusStateUnknown: - case XenbusStateClosed: break; case XenbusStateInitWait: @@ -1716,6 +1715,10 @@ static void netback_changed(struct xenbus_device *dev, netdev_notify_peers(netdev); break; + case XenbusStateClosed: + if (dev->state == XenbusStateClosed) + break; + /* Missed the backend's CLOSING state -- fallthrough */ case XenbusStateClosing: xenbus_frontend_closed(dev); break; -- 1.7.2.5