From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: RE: sock_getsockopt() not exported Date: Thu, 18 Oct 2012 14:27:55 +0200 Message-ID: <1350563275.26103.1465.camel@edumazet-glaptop> References: <1350552612.26103.1281.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: David Laight Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:59787 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754350Ab2JRM2B (ORCPT ); Thu, 18 Oct 2012 08:28:01 -0400 Received: by mail-bk0-f46.google.com with SMTP id jk13so4117083bkc.19 for ; Thu, 18 Oct 2012 05:28:00 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2012-10-18 at 13:03 +0100, David Laight wrote: > > On Thu, 2012-10-18 at 10:11 +0100, David Laight wrote: > > > I've noticed that net/core/sock.c contains an > > > EXPORT_SYMBOL(sock_setsockopt) > > > but is missing the corresponding > > > EXPORT_SYMBOL(sock_getsockopt) > > > > > > In-kernel users of sockets probably manage without > > > needing to read SOL_SOCKET options. > > > (They do need to set SO_REUSADDR and SO_KEEPALIVE.) > > > > sock_setsockopt() is exported because sunrpc needs it, and sunrpc can be > > a module > > > > sock_getsockopt() is not exported because no module needs it yet. > > > > The day one user needs it, we'll add the EXPORT_SYMBOL() > > The problem is that it might be needed by an 'out of tree' driver. > We already have the function: We dont care of out of tree drivers. Thats really simple. Submit this driver, and add the EXPORT_SYMBOL() you need at that time.