From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Florian Fainelli <ffainelli@freebox.fr>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Maxime Bizon <mbizon@freebox.fr>
Subject: Re: [PATCH] e1000: fix concurrent accesses to PHY from watchdog and ethtool
Date: Fri, 19 Oct 2012 23:47:34 -0700 [thread overview]
Message-ID: <1350715654.2213.22.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1350650688-29293-1-git-send-email-ffainelli@freebox.fr>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
On Fri, 2012-10-19 at 14:44 +0200, Florian Fainelli wrote:
> From: Maxime Bizon <mbizon@freebox.fr>
>
> The e1000 driver currently does not protect concurrent accesses to the
> PHY
> from both the ethtool callbacks, and from the e1000_watchdog function.
> This
> patchs adds a new spinlock which is used by e1000_{read,write}_phy_reg
> in
> order to serialize concurrent accesses to the PHY.
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> Signed-off-by: Florian Fainelli <ffainelli@freebox.fr>
> ---
> drivers/net/ethernet/intel/e1000/e1000_hw.c | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
It does not appear I have responded yet, so...
I have added this patch to my queue, thanks!
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-10-20 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 12:44 [PATCH] e1000: fix concurrent accesses to PHY from watchdog and ethtool Florian Fainelli
2012-10-20 6:47 ` Jeff Kirsher [this message]
2012-10-22 8:28 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350715654.2213.22.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=ffainelli@freebox.fr \
--cc=mbizon@freebox.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).