From: Eric Dumazet <eric.dumazet@gmail.com>
To: Vimalkumar <j.vimal@gmail.com>
Cc: davem@davemloft.net, Jamal Hadi Salim <jhs@mojatatu.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] htb: improved accuracy at high rates
Date: Sat, 20 Oct 2012 12:29:36 +0200 [thread overview]
Message-ID: <1350728976.13333.544.camel@edumazet-glaptop> (raw)
In-Reply-To: <1350685582-65334-1-git-send-email-j.vimal@gmail.com>
On Fri, 2012-10-19 at 15:26 -0700, Vimalkumar wrote:
> + if (likely(next_event > q->now)) {
> + if (!test_bit(__QDISC_STATE_DEACTIVATED,
> + &qdisc_root_sleeping(q->watchdog.qdisc)->state)) {
> + ktime_t time = ktime_set(0, 0);
> + qdisc_throttled(q->watchdog.qdisc);
> + time = ktime_add_ns(time, next_event);
> + hrtimer_start(&q->watchdog.timer, time,
> + HRTIMER_MODE_ABS);
> + }
> + } else
could use ns_to_ktime() helper
+ if (likely(next_event > q->now)) {
> + if (!test_bit(__QDISC_STATE_DEACTIVATED,
> + &qdisc_root_sleeping(q->watchdog.qdisc)->state)) {
> + qdisc_throttled(q->watchdog.qdisc);
> + hrtimer_start(&q->watchdog.timer, ns_to_ktime(next_event),
> + HRTIMER_MODE_ABS);
> + }
> + } else
I'll post a patch to cleanup net/sched/sch_api.c & net/sched/sch_cbq.c
prev parent reply other threads:[~2012-10-20 10:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 22:26 [PATCH] htb: improved accuracy at high rates Vimalkumar
2012-10-19 23:52 ` Rick Jones
2012-10-20 0:51 ` Vimal
2012-10-22 17:35 ` Rick Jones
2012-10-20 7:26 ` Eric Dumazet
2012-10-20 16:41 ` Vimal
2012-10-20 7:47 ` Eric Dumazet
2012-10-20 10:29 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350728976.13333.544.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=j.vimal@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox